GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — docs: adding field descriptions to predefined audio document by punndcoder28 · Pull Request #1774 · docarray/docarray

This repository was archived by the owner on Sep 9, 2026. It is now read-only.

Conversation

@punndcoder28

@punndcoder28 punndcoder28 commented Sep 5, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Adds field descriptions and example usage of each field for the predefined Audio document

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@punndcoder28
punndcoder28 force-pushed the docs_adding_field_description_audio_document branch from 106b51c to be3e2ee Compare September 5, 2023 17:18
punndcoder28
punndcoder28 commented Sep 5, 2023
View reviewed changes
Comment thread docarray/documents/audio.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
punndcoder28
punndcoder28 commented Sep 5, 2023
View reviewed changes
Comment thread docarray/documents/audio.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@punndcoder28
punndcoder28 marked this pull request as ready for review September 5, 2023 17:20
@codecov

codecov Bot commented Sep 5, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.13% 🎉

Comparison is base (715252a) 83.73% compared to head (c3097df) 83.87%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1774      +/-   ##
==========================================
+ Coverage   83.73%   83.87%   +0.13%     
==========================================
  Files         136      136              
  Lines        9040     9041       +1     
==========================================
+ Hits         7570     7583      +13     
+ Misses       1470     1458      -12
Flag Coverage Δ
docarray 83.87% <100.00%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
docarray/documents/audio.py 92.85% <100.00%> (+0.26%) ⬆️

... and 16 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
JoanFM
JoanFM suggested changes Sep 6, 2023
View reviewed changes
Comment thread docarray/documents/audio.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@punndcoder28
punndcoder28 force-pushed the docs_adding_field_description_audio_document branch from be3e2ee to 8a7538d Compare September 6, 2023 17:59
@punndcoder28
punndcoder28 requested a review from JoanFM September 6, 2023 17:59
@punndcoder28
punndcoder28 force-pushed the docs_adding_field_description_audio_document branch 2 times, most recently from f47ba11 to f9a1871 Compare September 8, 2023 17:04
JoanFM
JoanFM suggested changes Sep 14, 2023
View reviewed changes
Comment thread docarray/documents/audio.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread docarray/documents/audio.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread docarray/documents/audio.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread docarray/documents/audio.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread docarray/documents/audio.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@JoanFM

JoanFM commented Sep 14, 2023

Copy link
Copy Markdown
Member

To resolve the conflicts, make sure to add None as the default value for the Optional fields.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@punndcoder28
punndcoder28 force-pushed the docs_adding_field_description_audio_document branch 2 times, most recently from bd495f4 to ad71930 Compare September 14, 2023 16:51
@punndcoder28

punndcoder28 commented Sep 14, 2023

Copy link
Copy Markdown
Contributor Author

Fixed the typo and removed '''...''' wherever it was not needed
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@punndcoder28
punndcoder28 requested a review from JoanFM September 14, 2023 16:52
JoanFM
JoanFM suggested changes Sep 14, 2023
View reviewed changes
Comment thread docarray/documents/audio.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@punndcoder28
docs: adding field descriptions to predefined audio document
c3097df 
Signed-off-by: punndcoder28 <[email protected]>
@punndcoder28
punndcoder28 force-pushed the docs_adding_field_description_audio_document branch from ad71930 to c3097df Compare September 14, 2023 17:32
@punndcoder28
punndcoder28 requested a review from JoanFM September 14, 2023 17:32
JoanFM
JoanFM approved these changes Sep 14, 2023
View reviewed changes
@JoanFM
JoanFM merged commit 35d2138 into docarray:main Sep 14, 2023
@JoanFM JoanFM mentioned this pull request Oct 2, 2023
Release Notes #1817
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@JoanFM JoanFM JoanFM approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@punndcoder28 @JoanFM
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.