GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — feat: add BaseDocWoId by samsja · Pull Request #1803 · docarray/docarray

This repository was archived by the owner on Sep 9, 2026. It is now read-only.

Conversation

@samsja

@samsja samsja commented Sep 25, 2023

Copy link
Copy Markdown
Member

Context

allow to have doc without Id

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@github-actions github-actions Bot added size/s area/core labels Sep 25, 2023
samsja added 2 commits September 25, 2023 15:32
@samsja
feat: add BaseDocWoId
fde7a16 
Signed-off-by: samsja <[email protected]>
@samsja
fix: fix tests
f25dabc 
Signed-off-by: samsja <[email protected]>
@codecov

codecov Bot commented Sep 25, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (0148e99) 84.81% compared to head (fe4d7e0) 73.89%.

Additional details and impacted files 
@@             Coverage Diff             @@
##             main    #1803       +/-   ##
===========================================
- Coverage   84.81%   73.89%   -10.93%     
===========================================
  Files         135      135               
  Lines        8904     8905        +1     
===========================================
- Hits         7552     6580      -972     
- Misses       1352     2325      +973
Flag Coverage Δ
docarray 73.89% <100.00%> (-10.93%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
docarray/base_doc/doc.py 91.06% <100.00%> (-0.82%) ⬇️

... and 31 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
deepankarm
deepankarm approved these changes Sep 25, 2023
View reviewed changes
@samsja
refactor: raname to BaseDocWithoutId
e444c8d 
Signed-off-by: samsja <[email protected]>
@samsja
samsja requested a review from JoanFM September 26, 2023 07:22
JoanFM
JoanFM suggested changes Sep 26, 2023
View reviewed changes
Comment thread docarray/base_doc/doc.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@samsja
fix: add docstring
218290d 
Signed-off-by: samsja <[email protected]>
@github-actions github-actions Bot added size/m area/setup and removed size/s labels Sep 26, 2023
@samsja
chore: update mkdocstring
fe4d7e0 
Signed-off-by: samsja <[email protected]>
@github-actions

github-actions Bot commented Sep 26, 2023

Copy link
Copy Markdown

📝 Docs are deployed on https://ft-feat-doc-wo-id--jina-docs.netlify.app 🎉
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@samsja
samsja marked this pull request as ready for review September 26, 2023 08:30
@samsja
samsja merged commit 2a1cc9e into main Sep 26, 2023
@samsja
samsja deleted the feat-doc-wo-id branch September 26, 2023 08:31
@JoanFM JoanFM mentioned this pull request Oct 2, 2023
Release Notes #1817
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
@JoanFM JoanFM JoanFM requested changes
@deepankarm deepankarm deepankarm approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

area/core area/setup size/m

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@samsja @deepankarm @JoanFM
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.