GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix: validate before by samsja · Pull Request #1806 · docarray/docarray

This repository was archived by the owner on Sep 9, 2026. It is now read-only.

Conversation

@samsja

@samsja samsja commented Sep 27, 2023

Copy link
Copy Markdown
Member

Context

Allow to do ImageDoc('url') behavior for all of the predefined document.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
samsja added 6 commits September 27, 2023 10:10
@samsja
fix: fix TextDoc
a36fd7f 
Signed-off-by: samsja <[email protected]>
@samsja
fix: fix 3d tests
c72c5cc 
Signed-off-by: samsja <[email protected]>
@samsja
fix: fix 3d tests
b2ab488 
Signed-off-by: samsja <[email protected]>
@samsja
fix: fix audio tests
f1753f2 
Signed-off-by: samsja <[email protected]>
@samsja
fix: fix image doc
1b10188 
Signed-off-by: samsja <[email protected]>
@samsja
fix: fix video doc
72e80ae 
Signed-off-by: samsja <[email protected]>
@samsja
samsja marked this pull request as ready for review September 27, 2023 09:03
@samsja
samsja requested review from JoanFM and JohannesMessner September 27, 2023 09:03
@github-actions github-actions Bot added size/m area/core area/testing labels Sep 27, 2023
@samsja samsja linked an issue Sep 27, 2023 that may be closed by this pull request
[pydantic v2] Validation with default value is not working #1787
Closed
@github-actions github-actions Bot added the area/typing label Sep 27, 2023
@samsja samsja closed this Sep 27, 2023
@samsja samsja reopened this Sep 27, 2023
@samsja
fix: fix csv tests
591cdb6 
Signed-off-by: samsja <[email protected]>
@codecov

codecov Bot commented Sep 27, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (dce3907) 84.80% compared to head (aaec7fe) 84.20%.
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1806      +/-   ##
==========================================
- Coverage   84.80%   84.20%   -0.61%     
==========================================
  Files         135      135              
  Lines        8906     8969      +63     
==========================================
- Hits         7553     7552       -1     
- Misses       1353     1417      +64
Flag Coverage Δ
docarray 84.20% <94.68%> (-0.61%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
docarray/documents/audio.py 94.87% <100.00%> (+2.01%) ⬆️
docarray/documents/point_cloud/point_cloud_3d.py 94.59% <100.00%> (+2.28%) ⬆️
docarray/documents/video.py 95.12% <100.00%> (+1.78%) ⬆️
docarray/typing/tensor/ndarray.py 87.36% <ø> (+0.91%) ⬆️
docarray/documents/image.py 92.30% <94.11%> (+3.02%) ⬆️
docarray/documents/text.py 95.00% <93.33%> (-1.67%) ⬇️
docarray/documents/mesh/mesh_3d.py 88.88% <80.00%> (-11.12%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Joan Fontanals added 3 commits September 27, 2023 17:28
Joan Fontanals
Merge branch 'main' into fix-validate-before
4e44d98
Joan Fontanals Martinez
fix: fix import protected
5ad9474
Joan Fontanals Martinez
Merge branch 'fix-validate-before' of https://github.com/docarray/doc…
aaec7fe 
…array into fix-validate-before
@github-actions

github-actions Bot commented Sep 27, 2023

Copy link
Copy Markdown

📝 Docs are deployed on https://ft-fix-validate-before--jina-docs.netlify.app 🎉
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@JoanFM
JoanFM merged commit 26d776d into main Sep 27, 2023
@JoanFM
JoanFM deleted the fix-validate-before branch September 27, 2023 15:59
@JoanFM JoanFM mentioned this pull request Oct 2, 2023
Release Notes #1817
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@JoanFM JoanFM Awaiting requested review from JoanFM
@JohannesMessner JohannesMessner Awaiting requested review from JohannesMessner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

area/core area/testing area/typing size/m

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[pydantic v2] Validation with default value is not working

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@samsja @JoanFM
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.