GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix: allow nested model dump via docvec by samsja · Pull Request #1808 · docarray/docarray

This repository was archived by the owner on Sep 9, 2026. It is now read-only.

Conversation

@samsja

@samsja samsja commented Sep 28, 2023

Copy link
Copy Markdown
Member

Context

DocVec nested document could not serialize correctly using model_dump from pydantic v2.

This pr fix it by recursively deep copying the document whereas before it was just done at level 1

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@samsja
fix: allow nested model dump via docvec
8247440 
Signed-off-by: samsja <[email protected]>
@samsja samsja linked an issue Sep 28, 2023 that may be closed by this pull request
[pydantic v2] csv and pandas reader DocList with Nested Documents is not working #1783
Closed
@github-actions github-actions Bot added size/s area/core area/typing labels Sep 28, 2023
@samsja
samsja requested review from JoanFM and JohannesMessner September 28, 2023 11:59
@codecov

codecov Bot commented Sep 28, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (26d776d) 84.26% compared to head (f18ee76) 84.56%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1808      +/-   ##
==========================================
+ Coverage   84.26%   84.56%   +0.30%     
==========================================
  Files         135      135              
  Lines        8971     8979       +8     
==========================================
+ Hits         7559     7593      +34     
+ Misses       1412     1386      -26
Flag Coverage Δ
docarray 84.56% <100.00%> (+0.30%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
docarray/base_doc/doc.py 92.18% <100.00%> (+0.26%) ⬆️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot removed the area/typing label Sep 28, 2023
@samsja
fix: remove breakpont
a49d91a 
Signed-off-by: samsja <[email protected]>
@github-actions github-actions Bot added the area/testing label Sep 28, 2023
@samsja
fix: remove breakpont
f18ee76 
Signed-off-by: samsja <[email protected]>
@github-actions

github-actions Bot commented Sep 28, 2023

Copy link
Copy Markdown

📝 Docs are deployed on https://ft-fix-nested-model-dump--jina-docs.netlify.app 🎉
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@JoanFM
JoanFM marked this pull request as ready for review September 28, 2023 15:32
JoanFM
JoanFM approved these changes Sep 28, 2023
View reviewed changes
@JoanFM
JoanFM merged commit 4a1bc26 into main Sep 28, 2023
@JoanFM
JoanFM deleted the fix-nested-model-dump branch September 28, 2023 15:32
@JoanFM JoanFM mentioned this pull request Oct 2, 2023
Release Notes #1817
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@JohannesMessner JohannesMessner Awaiting requested review from JohannesMessner
1 more reviewer
@JoanFM JoanFM JoanFM approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

area/core area/testing size/s

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[pydantic v2] csv and pandas reader DocList with Nested Documents is not working

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@samsja @JoanFM
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.