GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix: allow config extension in pydantic v2 by samsja · Pull Request #1814 · docarray/docarray

This repository was archived by the owner on Sep 9, 2026. It is now read-only.

Conversation

@samsja

@samsja samsja commented Sep 29, 2023

Copy link
Copy Markdown
Member

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@samsja
fix: fix condig test
484d616 
Signed-off-by: samsja <[email protected]>
@samsja
samsja marked this pull request as ready for review September 29, 2023 13:04
@github-actions github-actions Bot added size/m area/core area/docs area/testing labels Sep 29, 2023
samsja added 2 commits September 29, 2023 15:04
@samsja
fix: fix config and docs
4db88b5 
Signed-off-by: samsja <[email protected]>
@samsja
fix: config acces for pyndaitc v2
642c266 
Signed-off-by: samsja <[email protected]>
@samsja
samsja requested a review from JoanFM September 29, 2023 13:11
JoanFM
JoanFM approved these changes Sep 29, 2023
View reviewed changes
@github-actions

github-actions Bot commented Sep 29, 2023

Copy link
Copy Markdown

📝 Docs are deployed on https://ft-fix-config--jina-docs.netlify.app 🎉
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@codecov

codecov Bot commented Sep 29, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (9a6b1e6) 84.61% compared to head (642c266) 84.62%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1814   +/-   ##
=======================================
  Coverage   84.61%   84.62%           
=======================================
  Files         135      135           
  Lines        9005     9006    +1     
=======================================
+ Hits         7620     7621    +1     
  Misses       1385     1385
Flag Coverage Δ
docarray 84.62% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
docarray/base_doc/doc.py 92.18% <100.00%> (ø)
docarray/base_doc/mixins/io.py 90.24% <100.00%> (+0.04%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
This was linked to issues Sep 29, 2023
Add pydantic v2 compatiblity #1597
Closed
[pydantic v2] Override config is not working #1784
Closed
@JoanFM
JoanFM merged commit 3da3603 into main Oct 2, 2023
@JoanFM
JoanFM deleted the fix-config branch October 2, 2023 07:30
@JoanFM JoanFM mentioned this pull request Oct 2, 2023
Release Notes #1817
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@JoanFM JoanFM JoanFM approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

area/core area/docs area/testing size/m

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[pydantic v2] Override config is not working Add pydantic v2 compatiblity

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@samsja @JoanFM
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.