GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — feat(array): allow for type object with DocList by corentinmarek · Pull Request #1829 · docarray/docarray

This repository was archived by the owner on Sep 9, 2026. It is now read-only.

Conversation

@corentinmarek

@corentinmarek corentinmarek commented Oct 31, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

See issue #1828 for context

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@corentinmarek
feat(array): allow for type object with DocList
1637c2b 
Signed-off-by: Corentin Marek <[email protected]>
@corentinmarek corentinmarek mentioned this pull request Oct 31, 2023
DocList raises exception for type object. #1828
Open
3 of 6 tasks
JoanFM
JoanFM reviewed Oct 31, 2023
View reviewed changes

@JoanFM JoanFM left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May we add a test to show what is exactly what we are aiming to enable or disable?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@JoanFM JoanFM linked an issue Oct 31, 2023 that may be closed by this pull request
DocList raises exception for type object. #1828
Open
3 of 6 tasks
@codecov

codecov Bot commented Oct 31, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.37%. Comparing base (522811f) to head (1637c2b).
⚠️ Report is 41 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1829      +/-   ##
==========================================
- Coverage   85.05%   84.37%   -0.68%     
==========================================
  Files         135      135              
  Lines        9031     9031              
==========================================
- Hits         7681     7620      -61     
- Misses       1350     1411      +61
Flag Coverage Δ
docarray 84.37% <ø> (-0.68%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

This branch has not been deployed

No deployments
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@JoanFM JoanFM JoanFM left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

DocList raises exception for type object.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@corentinmarek @JoanFM
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.