GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — refactor test of the torchtensor by ai-naymul · Pull Request #1837 · docarray/docarray

This repository was archived by the owner on Sep 9, 2026. It is now read-only.

Conversation

@ai-naymul

@ai-naymul ai-naymul commented Dec 20, 2023

Copy link
Copy Markdown
Contributor

@samsja ,
Could you please check the PR and let me know if is there any issue :)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ai-naymul
refactor test of the torchtensor
9369a9e 
Signed-off-by: Naymul Islam <[email protected]>
@codecov

codecov Bot commented Dec 20, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ff00b60) 83.61% compared to head (9369a9e) 85.07%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1837      +/-   ##
==========================================
+ Coverage   83.61%   85.07%   +1.45%     
==========================================
  Files         136      136              
  Lines        9255     9255              
==========================================
+ Hits         7739     7874     +135     
+ Misses       1516     1381     -135
Flag Coverage Δ
docarray 85.07% <ø> (+1.45%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
samsja
samsja approved these changes Dec 21, 2023
View reviewed changes

@samsja samsja left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks nice !

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ai-naymul reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@samsja

samsja commented Dec 21, 2023

Copy link
Copy Markdown
Member

I will let @JoanFM do the merge. For more context see discussion here: #1833 (comment)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@JoanFM
JoanFM merged commit 8de3e17 into docarray:main Dec 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@samsja samsja samsja approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@ai-naymul @samsja @JoanFM
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.