GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — feat: support list of strings for Weaviate by JoanFM · Pull Request #1852 · docarray/docarray

This repository was archived by the owner on Sep 9, 2026. It is now read-only.

Conversation

@JoanFM

@JoanFM JoanFM commented Feb 8, 2024

Copy link
Copy Markdown
Member

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@JoanFM
JoanFM requested a review from hsm207 February 8, 2024 14:58
@JoanFM JoanFM linked an issue Feb 8, 2024 that may be closed by this pull request
Enhancement to the weaviate datatypes support (text[], object, object[]) with WeaviateDocumentIndex #1849
Open
4 of 7 tasks
@github-actions github-actions Bot added size/s area/core labels Feb 8, 2024
@codecov

codecov Bot commented Feb 8, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 20.00000% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.71%. Comparing base (5037635) to head (b42a68b).
⚠️ Report is 29 commits behind head on main.

Files with missing lines Patch % Lines
docarray/index/backends/weaviate.py 20.00% 8 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1852      +/-   ##
==========================================
- Coverage   85.06%   82.71%   -2.35%     
==========================================
  Files         136      136              
  Lines        9260     9270      +10     
==========================================
- Hits         7877     7668     -209     
- Misses       1383     1602     +219
Flag Coverage Δ
docarray 82.71% <20.00%> (-2.35%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
hsm207
hsm207 reviewed Feb 8, 2024
View reviewed changes
Comment thread docarray/index/backends/weaviate.py Outdated
Comment on lines +727 to +728
int: 'number[]',
float: 'number[]',

@hsm207 hsm207 Feb 8, 2024

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a list of int in python should be mapped to 'int[]' in weaviate, since 'number[]' is for float64

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
hsm207
hsm207 suggested changes Feb 8, 2024
View reviewed changes

@hsm207 hsm207 left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for implementing this.

i just have 1 comment.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@JoanFM
feat: support list of strings for Weaviate
af219af
@JoanFM
JoanFM force-pushed the weaviate-support-list-str branch from 416a12d to af219af Compare February 8, 2024 22:07
hsm207
hsm207 approved these changes Feb 8, 2024
View reviewed changes
@JoanFM
test: add small test
7eaa05c
@github-actions github-actions Bot added the area/testing label Feb 12, 2024
@JoanFM
test: small test
b42a68b
@github-actions

github-actions Bot commented Feb 13, 2024

Copy link
Copy Markdown

📝 Docs are deployed on https://ft-weaviate-support-list-str--jina-docs.netlify.app 🎉
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

This branch has not been deployed

No deployments
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@hsm207 hsm207 hsm207 approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

area/core area/testing size/s

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Enhancement to the weaviate datatypes support (text[], object, object[]) with WeaviateDocumentIndex

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@JoanFM @hsm207
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.