GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix: fix DocList schema when using Pydantic V2 by JoanFM · Pull Request #1876 · docarray/docarray

This repository was archived by the owner on Sep 9, 2026. It is now read-only.

Conversation

@JoanFM

@JoanFM JoanFM commented Mar 8, 2024

Copy link
Copy Markdown
Member

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@JoanFM
fix: try to fix doclist schema
a864589
@github-actions github-actions Bot added size/s area/core component/array labels Mar 8, 2024
@codecov

codecov Bot commented Mar 8, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 70.42254% with 21 lines in your changes missing coverage. Please review.

Project coverage is 61.08%. Comparing base (82d7cee) to head (0f27ffa).
Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
docarray/__init__.py 56.66% 13 Missing ⚠️
docarray/utils/create_dynamic_doc_class.py 0.00% 5 Missing ⚠️
docarray/array/any_array.py 92.30% 1 Missing ⚠️
docarray/array/doc_list/doc_list.py 88.88% 1 Missing ⚠️
docarray/array/doc_vec/doc_vec.py 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##             main    #1876       +/-   ##
===========================================
+ Coverage   29.01%   61.08%   +32.06%     
===========================================
  Files         136      137        +1     
  Lines        9468     9628      +160     
===========================================
+ Hits         2747     5881     +3134     
+ Misses       6721     3747     -2974
Flag Coverage Δ
docarray 61.08% <70.42%> (+32.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@JoanFM
chore: push tmp changes
951679c
@github-actions github-actions Bot added size/m size/s and removed size/s size/m labels Mar 8, 2024
@JoanFM
JoanFM force-pushed the try-fix-doclist-schema branch 3 times, most recently from 12cd670 to 1f35aca Compare March 11, 2024 10:34
@JoanFM
fix: make DocList properly a Generic
febea8d
@JoanFM
JoanFM force-pushed the try-fix-doclist-schema branch from 1f35aca to febea8d Compare March 11, 2024 10:36
JoanFM added 2 commits March 11, 2024 11:48
@JoanFM
fix: make DocList properly a Generic
11eeb6a
@JoanFM
Merge branch 'try-fix-doclist-schema' of https://github.com/docarray/…
3f4707f 
…docarray into try-fix-doclist-schema
@JoanFM
JoanFM force-pushed the try-fix-doclist-schema branch 3 times, most recently from e8c3334 to dfb3c85 Compare March 11, 2024 17:53
@JoanFM
fix: undo some changes
a07919d
@JoanFM
JoanFM force-pushed the try-fix-doclist-schema branch from dfb3c85 to a07919d Compare March 12, 2024 08:44
@JoanFM JoanFM linked an issue Mar 12, 2024 that may be closed by this pull request
Bug: Jsonschema of DocList not correct #1521
Closed
@github-actions github-actions Bot added the area/testing label Mar 12, 2024
@JoanFM
JoanFM marked this pull request as ready for review March 12, 2024 15:25
@JoanFM JoanFM changed the title fix: try to fix doclist schema fix: Fix DocList schema when using Pydantic V2 Mar 12, 2024
@JoanFM JoanFM changed the title fix: Fix DocList schema when using Pydantic V2 fix: fix DocList schema when using Pydantic V2 Mar 12, 2024
@JoanFM
JoanFM force-pushed the try-fix-doclist-schema branch from c652ed2 to 8a57030 Compare March 12, 2024 15:32
@github-actions github-actions Bot added area/cicd area/housekeeping labels Mar 12, 2024
JoanFM added 2 commits February 25, 2025 18:15
@JoanFM
fix: small test fix
2f80c56
@JoanFM
test: change tests
5ff2f68
@JoanFM
JoanFM force-pushed the try-fix-doclist-schema branch from 4990a0f to 5ff2f68 Compare March 12, 2025 17:04
JoanFM added 4 commits March 13, 2025 09:48
@JoanFM
fix: try to fix all pydantic-v1 tests
00245aa
@JoanFM
fix: fix small dynamic creation
40f9420
@JoanFM
test: further fix tests
cb9cc94
@JoanFM
test: new iteration
4f42c0b
@JoanFM
JoanFM force-pushed the try-fix-doclist-schema branch from 0f27ffa to 4f42c0b Compare March 13, 2025 14:54
JoanFM added 3 commits March 14, 2025 09:22
@JoanFM
test: more tests
cfa7ea5
@JoanFM
fix: tests
659b992
@JoanFM
test: fix schemas from new model
9c94394
@JoanFM JoanFM closed this Mar 17, 2025
@JoanFM JoanFM reopened this Mar 17, 2025
@JoanFM JoanFM closed this Mar 17, 2025
@JoanFM JoanFM reopened this Mar 17, 2025
@github-actions github-actions Bot added size/l and removed size/m labels Mar 17, 2025
JoanFM added 6 commits March 18, 2025 10:21
@JoanFM
fix: improve cleaning refs
f422e88
@JoanFM
fix: get from definitions
c7e9bf6
@JoanFM
fix: remove unneeded argument
5d3e73f
@JoanFM
fix: fix update
e12c03a
@JoanFM
fix: handle ID optional
a6fef44
@JoanFM
fix: remove problematic action
559c0ee
@JoanFM JoanFM closed this Mar 18, 2025
@JoanFM JoanFM reopened this Mar 18, 2025
@JoanFM JoanFM closed this Mar 18, 2025
@JoanFM JoanFM reopened this Mar 18, 2025
@JoanFM
fix: fix resp as json
8265d95
@JoanFM
JoanFM merged commit d98acb7 into main Mar 21, 2025
@JoanFM
JoanFM deleted the try-fix-doclist-schema branch March 21, 2025 08:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

area/cicd area/core area/entrypoint area/housekeeping area/testing area/typing component/array size/l

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug: Jsonschema of DocList not correct

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@JoanFM
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.