GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — refactor(tui): remove write-only pointer state by dgageot · Pull Request #4843 · docker/docker-agent

Conversation

@dgageot

@dgageot dgageot commented Nov 9, 2026

Copy link
Copy Markdown
Member

Summary

Remove the write-only hasPointer field and its per-message reset check.

Mouse handling and view-cache invalidation remain unchanged because neither reads this state.

Standalone cleanup: one commit against main; no dependency on the other cleanup PRs.

Validation

  • task --force build
  • task test
  • task --force lint
  • Single signed commit verified; patch equivalent to the original commit.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@dgageot
refactor(tui): remove write-only pointer state
8d162df 
Assisted-By: OpenAI ChatGPT
Signed-off-by: David Gageot <[email protected]>
@dgageot
dgageot requested a review from a team as a code owner November 9, 2026 12:04
Copilot AI balanced review requested due to automatic review settings November 9, 2026 12:04
Copilot started reviewing on behalf of dgageot November 9, 2026 12:04
View session
Copilot AI reviewed Nov 9, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues block the removal of unused pointer state from the terminal UI.

No open issues 🎉

What changed in this PR

Removes unused pointer state from the terminal UI without changing mouse handling or view-cache invalidation.

Changes:

  • Deletes the write-only appModel.hasPointer field.
  • Removes its reset on non-mouse-motion messages.
File Description
pkg/​tui/​tui.go Removes the unused pointer field and its per-message reset.

Review effort: Balanced

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
rumpl
rumpl approved these changes Nov 9, 2026
View reviewed changes
@aheritier aheritier added area/tui For features/issues/fixes related to the TUI kind/refactor PR refactors code without behavior change labels Nov 9, 2026
@dgageot
dgageot added this pull request to the merge queue Nov 9, 2026
Merged via the queue into main with commit 5eae81b Nov 9, 2026
18 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@dgageot
dgageot deleted the refactor/tui-remove-write-only-pointer-state-5fb474729 branch November 9, 2026 13:59
@BrewTestBot BrewTestBot mentioned this pull request Nov 10, 2026
docker-agent 1.159.0 Homebrew/homebrew-core#324669
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@rumpl rumpl rumpl approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

area/tui For features/issues/fixes related to the TUI kind/refactor PR refactors code without behavior change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@dgageot @rumpl @aheritier
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.