GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — build(deps): remove unused lru-cache dependency by HeversonSilva-gif · Pull Request #256 · docsifyjs/docsify-cli

Conversation

@HeversonSilva-gif

@HeversonSilva-gif HeversonSilva-gif commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

lru-cache@^5.1.1 is declared in dependencies but is not imported anywhere in the
project. Its only occurrence in the whole repository is the package.json line itself.

Everyone who installs docsify-cli gets it, and nothing ever loads it.

Verified at b9d118f on Node 20.20.0 / npm 10.8.2, Windows:

  • git grep -E "(from|require\(|import\()\s*['\"]lru-cache" returns nothing, and a plain
    git grep for lru-cache or LRU outside the lockfile matches only package.json:61.

  • npm run build (rollup) after the change: exit 0, lib/cli.js → bin/docsify created as
    before. Nothing was being bundled from it either.

  • npm test before the change: 9 tests failed. After the change: 9 tests failed. The
    set of failing titles is identical, diffed rather than counted:

    cli › shows up help message without any args
    cli › shows help with -h flag
    cli › shows help with --help flag
    cli › shows version information with -v flag
    cli › shows version information with --version flag
    cli › rejects promise due to error on passing in an unknown command
    commands › generate › generate _sidebar.md
    commands › init › generates docs directory
    commands › init › force generates docs directory with --local flag
    

    Those 9 are pre-existing on this machine and unrelated to this change — they are the
    e2e tests that shell out, and they fail the same way on a clean checkout. pretest runs
    eslint ., which is clean on both sides.

  • npm install reports removed 2 packages: lru-cache and yallist, which came in only
    as its dependency.

I have not touched anything else. If you would rather I re-run the suite somewhere the e2e
tests pass before this is merged, I'm happy to, but the failing set being identical is what
tells you the change is inert.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@HeversonSilva-gif
build(deps): remove unused lru-cache dependency
57950f7
sy-records
sy-records approved these changes Aug 4, 2026
View reviewed changes

@sy-records sy-records left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

It was previously referenced in SSR, but now that SSR has been removed, it is no longer needed.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@sy-records
sy-records merged commit bca45f5 into docsifyjs:master Aug 4, 2026
4 checks passed

Uh oh!

There was an error while loading. Please reload this page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sy-records sy-records sy-records approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@HeversonSilva-gif @sy-records
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.