GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Draft: GTK3: Do not merge by MakiWolf · Pull Request #149 · dotdevelop/dotdevelop

Conversation

MakiWolf commented Jan 4, 2024

Copy link

Copy Markdown

Draft: GTK3: Do not merge

This PR fixes merge conflicts with this PR #10

To compile gtksharp3 package must be installed.

Many things does not work as expected and must be replaced, because currently it is only to compile but not to work. But it displays the main ide window.

In future we should also switch to nuget packages and go back to the submodules from dotdevelop. I also have to change the submodules xwt and mono addins to older versions because of compile errors between nuget gtk and gtk from mono package at the beginning.

And also this file is now an old version to get dotdevelop compile.

https://github.com/MakiWolf/dotdevelop/blob/main/main/src/core/MonoDevelop.Ide/MonoDevelop.Components/GtkWorkarounds.cs

It have also a lot of #if DD_GTK3_CHECK_FOR_REMOVE statements

I also saw that @lytico have started with if else statements in gtk3. I found this idea good beacuse we can switch between gtk2 and gtk3 until all things work as expected and replaced with newer code. I dont know if there is a possibility to add if else statements automatically for changes or we have to edit every single file manual?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Jo Shields and others added 30 commits

July 23, 2018 10:45


          Remove Stetic Gtk#2 GUI designer

6ca69b5

Stetic is what sold me on MonoDevelop in the first place, more than a decade ago. A high quality GUI designer, fully integratwd into the IDE, on Linux, was bliss - as compared to the state of the art of `glade-2` XML files at the time.

However.

In 2018, it is effectively dead weight for us.

Visual Studio for Mac is not a Gtk# IDE, and does not benefit from Gtk# app authoring support. And, crucially, Stetic depends heavily on the internals of libglade, which no longer exists in Gtk+ 3.0+.

In order to move forwards with porting MonoDevelop to Gtk#3, Stetic in its current incarnation needs to go away. All the internals need rewriting, and we cannot justify the engineer time required to do that ourselves. So, like our C/C++ support, remove it & focus on the fundamentals.

This removal removes support for creating new Gtk# projects (as the templates are in MonoDevelop.GtkCore), but it can still open/compile existing Gtk# projects fine.


          Remove lingering glade-sharp references

1db6b06


          Port to Gtk#3


          moop

abca952


          moop


          current wip

17d164b


          Made it show an error popup!

6297e23


          More build fixes

b16963a


          More build fixes

d30cfab


          Always use ToolkitType.Gtk3 for XWT

ed1ab72


          Retrieve version number in a non-weird way

feb07e0


          Work around lack of font loading, due to style service stubs

d7a532b


          Get something displaying!!!

e5ae6e7


          Fix natural_* == 0 in OnGetPreferred* events

85160e1


          Minor natural_height fix

b615c4e


          My first port from OnExposeEvent to OnDrawn

c5374d0


          Fix Gtk3 on Mac

02d2dae


          Better Linux OS name detection in Help/About

765a54d


          more updates

0b740ae


          More sourceeditor fixes

bcc8c79


          More build stubbing

6606b91


          Bump Xwt submodule, for Mac dllmap fix

b08b7c5


          Update

fd4af9e


          Update MonoDevelop.AspNet.csproj

7da6b8e


          Update MonoDevelop.AspNet.Tests.csproj

2813a07


          Update CSharpBinding.AspNet.csproj


          Update CSharpBinding.csproj

c0099bf


          Update ChangeLogAddIn.csproj

ba6a7b5


          Update MonoDevelop.Deployment.Linux.csproj

22543e7


          Update MonoDevelop.Deployment.csproj

962d499

MakiWolf and others added 25 commits

December 10, 2023 17:22


          Update ExternalToolPanel.cs

6d3fedf


          Update TooltipProvider.cs

8b850d6


          Update CodeTemplatePanel.cs

3286be4


          Update Tabstrip.cs

a951afc


          Update PathBar.cs

e04934e


          Update HPanedThin.cs

8ff734c


          Update ReferencesGtk.props

cef1c3b


          Update MonoDevelop.DesignerSupport.Toolbox.ComponentSelectorDialog.cs

290e13a


          Update SearchEntry.cs

91197e8


          Update PadTreeView.cs

5d7c294


          Update SelectReferenceDialog.cs

bc91295


          change to own fork

3d4dc52


          update

505e1ee


          update

2e2670c


          update

8fe8797


          update

d330325


          older version

528a10e


          comment out

d884937


          comment out

b572709


          fix startup

f383041


          move references

530a73c


          delete crash

949ddc3


          fix reference

a236687


          update references

ae129a3


          update references

a2276de

knocte commented Jan 5, 2024

Copy link

Copy Markdown

Member

IMNSHO this is the wrong approach. Because I think you're porting to master/main branch of https://github.com/mono/gtk-sharp , which is a stagnated project (I know this very well because I contributed a lot of commits to it, especially the main branch [1]). Any decent GTKvNext port should not focus on these libraries and not 3.x, but other libraries which, by now, must be offering even newer versions (e.g. 4.x), like https://github.com/gtksharp/gtksharp

[1] So yeah, I take it big part of the blame for it to be stagnated.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

MakiWolf commented Jan 6, 2024

Copy link

Copy Markdown

Author

I have set up a new branch to update from mono gtk to nuget gtksharp.
A lot of things have to be commented out here more. But it does compile and but will not start.

https://github.com/MakiWolf/dotdevelop/tree/hackweek2nugetgtk

./start.sh
FATAL ERROR [2024-01-06 19:33:27Z]: MonoDevelop failed to start. Some of the assemblies required to run MonoDevelop (for example gtk-sharp)may not be properly installed in the GAC.
System.IO.FileNotFoundException: Could not load file or assembly 'GtkSharp, Version=3.24.24.95, Culture=neutral, PublicKeyToken=f6892ebcc5dd81ba' or one of its dependencies.
File name: 'GtkSharp, Version=3.24.24.95, Culture=neutral, PublicKeyToken=f6892ebcc5dd81ba'
  at MonoDevelop.Ide.IdeStartup.Main (System.String[] args, MonoDevelop.Ide.Extensions.IdeCustomizer customizer) [0x000d4] in <f38a47e826674fb69787c678b221caf5>:0

The exception comes from this line:
https://github.com/MakiWolf/dotdevelop/blob/9b071207773b1073b0d66c4dbc2142de0516ada5/main/src/core/MonoDevelop.Ide/MonoDevelop.Ide/IdeStartup.cs#L756

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

MakiWolf mentioned this pull request

Jan 7, 2024

Draft: nugetgtk3 #150

Open

MakiWolf commented Jan 7, 2024

Copy link

Copy Markdown

Author

Opened up a new PR for nuget gtksharp
#150

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

MakiWolf closed this

Jan 7, 2024

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.