GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |
GeezerVison is showing github.com — Add leading SQL comment support via :label for queries and insert/upd… by alesasnouski · Pull Request #731 · elixir-ecto/ecto_sql ConversationHi, This is the adapter/SQL side of the :label feature — companion to the Ecto PR that adds Ecto.Query.label/2. It renders the leading /* ... */ comment in the generated SQL. There are two paths: Queries (all/update_all/delete_all): each adapter's connection module prepends /* label */ from query.label, before the SELECT/UPDATE/DELETE. The option-side validation rejects /*, */ and null bytes, mirroring the query-side validation in Ecto, so the label can't break out of the comment. Tested against Postgres, MySQL and SQL Server, verifying the comment reaches the server (general log / Extended Events), not just the client-side Ecto log.
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Member
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ReviewersNo reviewsUh oh!
There was an error while loading. Please reload this page. AssigneesNo one assignedLabels
None yet
ProjectsMilestoneNo milestoneDevelopmentSuccessfully merging this pull request may close these issues. Uh oh!
There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. | |
| You are visitor 01402520 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |