GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add windows compatibility for tests by collerek · Pull Request #454 · encode/databases

This repository was archived by the owner on Aug 19, 2025. It is now read-only.

Conversation

@collerek

@collerek collerek commented Jan 25, 2022

Copy link
Copy Markdown
Contributor

Add windows support for tests:

  • different path to venv scripts
  • aiopg needs a workaround with event loop setting on py3.8+

Should be reviewed after #453 is merged to highlight only relevant changes

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
collerek added 2 commits January 25, 2022 12:57
@collerek
add support for local tests in docker
6e36535
@collerek
update docs
002e579
@collerek
collerek requested a review from aminalaee January 25, 2022 17:36
@collerek
Merge branch 'master' into add-windows-compatibility-for-tests
175be5a
@collerek collerek mentioned this pull request Jan 31, 2022
Add contributing docs #453
Merged
@aminalaee

aminalaee commented Feb 1, 2022

Copy link
Copy Markdown
Contributor

Let's wait for the base branch to be dealt with so we can review this. But I like the windows compatibility approach anyway.

Maybe we can also add it to the GitHub Actions.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

This branch has not been deployed

No deployments
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@aminalaee aminalaee Awaiting requested review from aminalaee

At least 1 approving review is required to merge this pull request.

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@collerek @aminalaee
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.