GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Adding more to decorator docs by jocho-here · Pull Request #489 · encode/databases

This repository was archived by the owner on Aug 19, 2025. It is now read-only.

Conversation

jocho-here commented May 17, 2022

Copy link

Copy Markdown

I wasn't able to find a way to properly use the transaction decorator when using with other decorators in the docs.
I thought it would be helpful to add this portion so others can also be aware they need to put the decorator right above the function signature without going into the code and finding out about it themselves.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

mgjo5899 and others added 3 commits

May 17, 2022 01:10


          adding more to decorator docs

eb328d5


          Merge branch 'master' into adding-to-decorator-usage-docs

934d126


          Merge branch 'master' into adding-to-decorator-usage-docs

31d996c

aminalaee reviewed

Jun 10, 2022

View reviewed changes

Comment thread

docs/connections_and_transactions.md

		```python
		@router.post("/my-awesome-endpoint")
		@database.transaction()
		async def awesome_endpoint():

aminalaee Jun 10, 2022

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be better to mention something general that "If using multiple decorators, the @database.transaction() should be the most inner to the function definition. But maybe with better wording 😄

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

This branch has not been deployed

No deployments

Reviewers

1 more reviewer

aminalaee

aminalaee left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.