GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Drop stale unavailable pool connections by Mirochill · Pull Request #1084 · encode/httpcore

Conversation

@Mirochill

@Mirochill Mirochill commented May 20, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Summary

  • remove an assigned connection from the pool if it still reports itself as available after raising ConnectionNotAvailable
  • prevent HTTP/2 connections that have received GOAWAY from advertising availability
  • add sync and async regression coverage for stale available connections

Closes #1066.

Checklist

  • I understand that this PR may be closed in case there was no previous discussion. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • Documentation is not updated because this is an internal connection-pool bug fix.

Validation

  • Not run locally
  • Static validation only: git diff --check.
  • Relying on GitHub Actions for remote validation.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@Mirochill
Mirochill force-pushed the fix-1066-drop-stale-unavailable-connection branch 5 times, most recently from f87199d to d718225 Compare May 20, 2026 12:49
@Mirochill
Drop stale unavailable pool connections
301e4c2
@Mirochill
Mirochill force-pushed the fix-1066-drop-stale-unavailable-connection branch from d718225 to 301e4c2 Compare May 20, 2026 12:52
@Mirochill
Mirochill marked this pull request as ready for review May 20, 2026 12:59
@mbeijen

mbeijen commented May 20, 2026

Copy link
Copy Markdown

There are multiple PRs for similar issues open in this repository; but there has not been much activity lately. In httpxyz, most of these issues have now been fixed and I've been upstreaming fixes (not these ones yet) to httpx2.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Stale connection stays in pool after ConnectionNotAvailable

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@Mirochill @mbeijen
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.