GeezerVison is showing github.com — Drop stale unavailable pool connections by Mirochill · Pull Request #1084 · encode/httpcore
Conversation
Mirochill
commented
May 20, 2026
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
Summary
- remove an assigned connection from the pool if it still reports itself as available after raising
ConnectionNotAvailable
- prevent HTTP/2 connections that have received GOAWAY from advertising availability
- add sync and async regression coverage for stale available connections
Closes #1066.
Checklist
- I understand that this PR may be closed in case there was no previous discussion. (This doesn't apply to typos!)
- I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
- Documentation is not updated because this is an internal connection-pool bug fix.
Validation
- Not run locally
- Static validation only:
git diff --check.
- Relying on GitHub Actions for remote validation.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
There are multiple PRs for similar issues open in this repository; but there has not been much activity lately. In httpxyz, most of these issues have now been fixed and I've been upstreaming fixes (not these ones yet) to httpx2.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This branch has not been deployed
No deployments
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.