GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — pytest anyio by aminalaee · Pull Request #101 · encode/orm

This repository was archived by the owner on Aug 19, 2025. It is now read-only.

Conversation

@aminalaee

@aminalaee aminalaee commented Aug 20, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Add pytest anyio

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Ultraproduct and others added 9 commits July 31, 2020 10:16
Ultraproduct Ultraproduct
Implement order by
f55003f
@aminalaee
Merge branch 'master' into implement-order-by
4e0f960
@aminalaee
format fix
559f023
@aminalaee
fix imports
63637de
@aminalaee
minor cleanups
55a9dd6
@aminalaee
try different async_adapter
97eefa1
@aminalaee
revert async_adapter
89657f8
@aminalaee
add python3.8
7ba7337
@aminalaee
add pytest-asyncio
fe92528
graingert
graingert suggested changes Aug 20, 2021
View reviewed changes

@graingert graingert left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be best to use @pytest.mark.anyio

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@aminalaee

aminalaee commented Aug 20, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

@graingert Thanks. But anyio is not required in orm. Do you mean we add that too?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@graingert

graingert commented Aug 20, 2021

Copy link
Copy Markdown
Contributor

afaik, orm and databases are designed with Starlette in mind and so should also work with anyio eventually
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@aminalaee
aminalaee requested a review from graingert August 20, 2021 10:10
@aminalaee aminalaee changed the title pytest-asyncio pytest-anyio Aug 24, 2021
@aminalaee
add anyio
889812a
graingert
graingert suggested changes Aug 24, 2021
View reviewed changes

@graingert graingert left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

anyio is only a test dep for now

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread setup.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread setup.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
aminalaee and others added 2 commits August 24, 2021 15:58
@aminalaee @graingert
Update setup.py
d8eef31 
Co-authored-by: Thomas Grainger <[email protected]>
@aminalaee
add anyio to test requirements.txt
89839b4
@aminalaee
aminalaee requested a review from graingert August 24, 2021 11:46
aminalaee added 2 commits August 24, 2021 16:18
@aminalaee
remove pytest-asyncio
8ad7457
@aminalaee
rebase master
b8ccba2
@aminalaee aminalaee changed the title pytest-anyio pytest anyio Aug 24, 2021
@aminalaee
aminalaee merged commit ec54759 into encode:master Aug 24, 2021
@aminalaee
aminalaee deleted the pytest-asyncio branch August 24, 2021 12:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@graingert graingert Awaiting requested review from graingert

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@aminalaee @graingert
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.