GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Allow Keep Alives for 201 & 404 Responses. by tomlea · Pull Request #7 · eventmachine/evma_httpserver

Conversation

@tomlea

@tomlea tomlea commented Mar 25, 2011

Copy link
Copy Markdown

Our app (used internally in @reevoo) is posting many (1000/s) small requests over SSL with certificate verification on either side. Connection setups are very expensive, so we use keep alive and connection recycling.

Our service responds with a 201 when a record is posted and a 404 when a get on a missing record happens.

This patch means that only 5xx responses force a connection reset.

I've also added some test coverage.

Let me know what you think.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@tomlea
Keep alive for all status codes but 5xx
b96beb4 
A 404/201 response does not indicate that the connection is unviable.
@alor

alor commented Apr 15, 2011

Copy link
Copy Markdown
Contributor

i like to see this merged to master. i was doing the same on my fork...
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@tomlea @alor
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.