GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Clean up phone number formatting (#1015) · ex1234/JavaScript@c865654

File tree

Expand file treeCollapse file tree
Open diff view settings
Filter options
  • String
    • FormatPhoneNumber.js
    • test
      • FormatPhoneNumber.test.js
Expand file treeCollapse file tree
Open diff view settings
Collapse file

‎String/FormatPhoneNumber.js‎

Copy file name to clipboard
+12-13Lines changed: 12 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,16 @@
1-
// function that takes 10 digits and returns a string of the formatted phone number
2-
// e.g.: 1234567890 -> (123) 456-7890
3-
4-
const formatPhoneNumber = (numbers) => {
5-
const numbersString = numbers.toString()
6-
if ((numbersString.length !== 10) || isNaN(numbersString)) {
1+
/**
2+
* @description - function that takes 10 digits and returns a string of the formatted phone number e.g.: 1234567890 -> (123) 456-7890
3+
* @param {string} phoneNumber
4+
* @returns {string} - Format to (XXX) XXX-XXXX pattern
5+
*/
6+
const formatPhoneNumber = (phoneNumber) => {
7+
if ((phoneNumber.length !== 10) || isNaN(phoneNumber)) {
78
// return "Invalid phone number."
8-
throw new TypeError('Invalid phone number.')
9+
throw new TypeError('Invalid phone number!')
910
}
10-
const arr = '(XXX) XXX-XXXX'.split('')
11-
Array.from(numbersString).forEach(n => {
12-
arr[arr.indexOf('X')] = n
13-
})
14-
return arr.join('')
11+
12+
let index = 0
13+
return '(XXX) XXX-XXXX'.replace(/X/g, () => phoneNumber[index++])
1514
}
1615

17-
export { formatPhoneNumber }
16+
export default formatPhoneNumber
Collapse file

‎String/test/FormatPhoneNumber.test.js‎

Copy file name to clipboard
+9-17Lines changed: 9 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -1,23 +1,15 @@
1-
import { formatPhoneNumber } from '../FormatPhoneNumber'
2-
3-
describe('PhoneNumberFormatting', () => {
4-
it('expects to return the formatted phone number', () => {
5-
expect(formatPhoneNumber('1234567890')).toEqual('(123) 456-7890')
6-
})
7-
8-
it('expects to return the formatted phone number', () => {
9-
expect(formatPhoneNumber(1234567890)).toEqual('(123) 456-7890')
10-
})
1+
import formatPhoneNumber from '../FormatPhoneNumber'
112

3+
describe('Testing the formatPhoneNumber functions', () => {
124
it('expects to throw a type error', () => {
13-
expect(() => { formatPhoneNumber('1234567') }).toThrow('Invalid phone number.')
5+
expect(() => formatPhoneNumber('1234567')).toThrow('Invalid phone number!')
6+
expect(() => formatPhoneNumber('123456text')).toThrow('Invalid phone number!')
7+
expect(() => formatPhoneNumber(12345)).toThrow('Invalid phone number!')
148
})
159

16-
it('expects to throw a type error', () => {
17-
expect(() => { formatPhoneNumber('123456text') }).toThrow('Invalid phone number.')
18-
})
19-
20-
it('expects to throw a type error', () => {
21-
expect(() => { formatPhoneNumber(12345) }).toThrow('Invalid phone number.')
10+
it('expects to return the formatted phone number', () => {
11+
expect(formatPhoneNumber('1234567890')).toEqual('(123) 456-7890')
12+
expect(formatPhoneNumber('2124323322')).toEqual('(212) 432-3322')
13+
expect(formatPhoneNumber('1721543455')).toEqual('(172) 154-3455')
2214
})
2315
})

0 commit comments

Comments
0 (0)
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.