GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Fix Vue error handler, Node query string, and React Native cleanup by ejsmith · Pull Request #212 · exceptionless/Exceptionless.JavaScript

Conversation

ejsmith commented Nov 4, 2026

Copy link

Copy Markdown

Member

Small, verified bug fixes.

Issue	Fix
Fixes #203	The Vue `ExceptionlessErrorHandler` put the whole component instance on the event, which froze the page while serializing. It now records the component name and `info`. Its signature takes `err: unknown`, so `app.config.errorHandler = ExceptionlessErrorHandler` compiles under strict TypeScript.
Fixes #204	Node request info filled `query_string` from route params. It now uses `request.query`.
Fixes #205	Removed the React Native storage fallback that could never run. AsyncStorage is a required peer dependency.
Fixes #206	The README and skill now say the Expo config plugin is optional. Native linking happens through autolinking.

Checks: npm run build, npm run lint and npm test (351 tests) pass. Adds a vue test project with tests for the handler.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

chatgpt-codex-connector[bot] reacted with thumbs up emoji

All reactions

👍 1 reaction

ejsmith added 4 commits

November 4, 2026 13:36


          Fix Vue error handler serializing the component instance (#203)

bf747de

Record the component name and Vue's info string instead of the whole
instance, and accept Vue's errorHandler signature so the documented
app.config.errorHandler assignment compiles under strict TypeScript.


          Fix Node request info using route params as the query string (#204)

c23ed13


          Remove the unreachable React Native in-memory storage fallback (#205)

ad5cd62

Nothing in the try block could throw, and a missing AsyncStorage native
module fails when the package is imported, so the fallback and its log
message never ran. AsyncStorage remains a required peer dependency.


          Fix docs that describe the no-op Expo config plugin as required (#206)

c71997c

Copilot AI balanced review requested due to automatic review settings

November 4, 2026 19:55

chatgpt-codex-connector Bot commented Nov 4, 2026 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-11-04T19:56:43.531492Z	`c71997c`	PR opened

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Copilot started reviewing on behalf of ejsmith

November 4, 2026 19:58

View session

Copilot AI reviewed

Nov 4, 2026

View reviewed changes

Copilot AI left a comment

Copy link

Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Repeated query parameters still produce array-valued query_string entries in violation of the string-valued contract, and the main skill retains contradictory Expo plugin setup guidance.

2 open issues

What changed in this PR

This PR fixes request and error reporting in the Vue and Node SDKs, removes unreachable React Native storage fallback code, and clarifies Expo setup.

Changes:

Reports Vue component names instead of serializing component instances, accepts unknown errors, and adds handler tests.
Captures Node query parameters from request.query rather than route parameters, with regression tests.
Removes the ineffective AsyncStorage fallback and documents the Expo plugin as optional.

File	Description
`vitest.config.ts`	Adds the Vue test project.
`packages/vue/test/ExceptionlessErrorHandler.test.ts`	Tests component metadata and error handling.
`packages/vue/src/index.ts`	Replaces instance serialization with component names.
`packages/vue/README.md`	Documents captured error metadata.
`packages/react-native/src/ReactNativeExceptionlessClient.ts`	Removes unreachable storage fallback code.
`packages/react-native/README.md`	Clarifies optional Expo plugin usage.
`packages/node/test/plugins/NodeRequestInfoPlugin.test.ts`	Tests query capture and missing queries.
`packages/node/src/plugins/NodeRequestInfoPlugin.ts`	Reads query data from `request.query`.
`.agents/skills/exceptionless-javascript/references/client-vue.md`	Documents Vue error metadata.
`.agents/skills/exceptionless-javascript/references/client-react-native.md`	Updates Expo setup and autolinking troubleshooting.

_{Review effort: Balanced}

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

packages/node/src/plugins/NodeRequestInfoPlugin.ts


		if (config.includeQueryString) {
		const json = stringify(request.params, exclusions);
		const json = stringify(request.query, exclusions);

Comment thread

.agents/skills/exceptionless-javascript/references/client-react-native.md

		```

		For Expo development or standalone builds, add the config plugin:
		No config plugin is required: the native crash reporter pod is linked by autolinking. The optional config plugin currently makes no native changes:

Reviewers

Copilot code review Copilot

Copilot review effort

Applies to this pull request for everyone.Learn more about Copilot code review.

Copilot left review comments

At least 1 approving review is required to merge this pull request.

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Expo config plugin is a no-op but is documented as needed for native crash reporting React Native in-memory storage fallback can never run Node request info fills query_string from route params instead of the query string Vue ExceptionlessErrorHandler serializes the whole component instance and freezes the page

Uh oh!

There was an error while loading. Please reload this page.

2 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

ejsmith commented Nov 4, 2026

Uh oh!

chatgpt-codex-connector Bot commented Nov 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codex Review Summary

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

chatgpt-codex-connector Bot commented Nov 4, 2026 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.