GeezerVisonThe World Wide Web, restored to 800 pixels of glory. |
| Home|About|Gaming cabinet|Archives|How it works|Starter sites |
GeezerVison is showing github.com — fix(graph_search): avoid KeyError in BFS when a node has no outgoing edges by Saadanjum0 · Pull Request #506 · faif/python-patterns Conversation
Contributor
The other traversal methods on this class ( Repro before the fix: graph = {"A": ["B"], "B": ["C", "D"]} # C and D are leaf nodes, no key in graph GraphSearch(graph).find_shortest_path_bfs("A", "Z") # KeyError: 'D' Added a regression test ( Ran the full suite locally with the new test passing. Also ran
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions…edges find_shortest_path_bfs indexed self.graph[value] directly while expanding the queue. Any node reachable in the graph but not present as a key (a leaf node with no outgoing edges, as in a typical adjacency list) raised a KeyError instead of being treated as having no neighbors. The DFS methods already handle this correctly via self.graph.get(start, []); bring BFS in line with that and add a regression test. Uh oh!
There was an error while loading. Please reload this page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ReviewersNo reviewsUh oh!
There was an error while loading. Please reload this page. AssigneesNo one assignedLabels
None yet
ProjectsMilestoneNo milestoneDevelopmentSuccessfully merging this pull request may close these issues. Uh oh!
There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. |
| You are visitor 01402503 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |