GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — newline issue when shader patching on windows · Issue #1098 · fastplotlib/fastplotlib

newline issue when shader patching on windows #1098

New issue
Copy link
New issue
Copy link
Open
Open
newline issue when shader patching on windows#1098
Copy link

Description

@Vipitis
Vipitis
opened on Oct 7, 2026
Issue body actions

Hey,

so I run into this a few times while fixing pyodide issues with the new release (and I am currently running into some race conditions with raising - so this was not making it easier). Turns out the problem is with windows.

You emit this user warning UserWarning: fpl highlight: anchor '@fragment\nfn fs_main' not found in image.wgsl FS entry WGSL. Highlighting disabled for this graphic type. This is likely caused by a pygfx version change, update the anchor string. But the assembly still fails leading to a validation error.

I had this happen with the example imgui_colorbar.py but there is likely others that also make use of your shader patching.

What happens is that get_code() returns different newlines on windows. The classic \r\n which of course doesn't match the expected \n for your anchors. To me this is actually something that should be fixed in pygfx, but as a quick workaround you can just do .replace("\r\n", "\n").

Maybe this doesn't happen to wheels built on CI, but I am on editable builds of the whole stack (wgpu-py, pygfx, fastplotlib; all on main)?

I think this is part of the whole custom shader maintenance discussion.

Activity

  1. kushalkolar commented on Oct 9, 2026

    @kushalkolar
    kushalkolar
    on Oct 9, 2026
    Member
    More actions

    I think that quick workaround is a good idea!

    We do have 2 separate CI builds, one with the latest pygfx release and one with pygfx@main. But we don't have use windows runners which is why this slipped through.

    Reacted by Jan
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      You are visitor 01402503 — GeezerVison does not store the pages you look up.
      Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.