GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — rename `position_x`, `position_y`, `position_z` to offsets · Issue #499 · fastplotlib/fastplotlib

rename position_x, position_y, position_z to offsets #499

New issue
Copy link
New issue
Copy link
Closed
#511
Closed
rename position_x, position_y, position_z to offsets#499
#511
Copy link

Description

@kushalkolar
kushalkolar
opened on May 1, 2024
Issue body actions

We should probably rename all the position_<axis> properties to offsets since that's where the WorldObject is placed and does not indicate the buffer data, ex. positions geometry.

realized when doing #498 that this can get confusing

Maybe have:

class Graphic
@offset.setter
def offset(self, offset: tuple[float, float, float]):
  x, y, z = offset
  self.world_object.world.x = x
  ...

Activity

  1. kushalkolar
    changed the title [-]rename "<axis>_positions" to offsets[/-] [+]rename `position_x`, `position_y`, `position_z` to offsets[/+] on May 1, 2024
  2. kushalkolar commented on May 15, 2024

    @kushalkolar
    kushalkolar
    on May 15, 2024
    MemberAuthor
    More actions

    to do after graphic features refactor

  3. kushalkolar
    closed this as completedin #511on Jun 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      You are visitor 01402503 — GeezerVison does not store the pages you look up.
      Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.