Description

clewis7

opened on Feb 18, 2025

Issue body actions

I know we are thinking about changing the set_ methods to have some more uniformity but just wanted to document this

If a title is set using set_title after figure creation, the title does get updated but the name attribute does not get updated

Also, we are never exposing the text graphic anywhere to be modified. For example, changing the color of text after the title has been set.

Lastly, I think it is a big ambiguous to have title vs. name. I think we should pick one or the other to make things uniform. My preference would be to use name... you can give graphics names, you can give figures names etc.

Activity

1. kushalkolar commented on Feb 19, 2025

   

   kushalkolar

   on Feb 19, 2025

   Member

   More actions

   Name is what you can use as a getter, but the title should be allowed to be anything. For example if the title has latex formatting and is long we don't want to use that as the getter too!
2. clewis7 commented on Feb 19, 2025

   

   clewis7

   on Feb 19, 2025

   MemberAuthor

   More actions

   So you are saying name and title can be two different things?
3. clewis7 commented on Feb 19, 2025

   

   clewis7

   on Feb 19, 2025

   MemberAuthor

   More actions

   I see that would make sense for indexing into a figure

   figure["subplot1"]["graphic1"]

   where the title of that subplot is "kmeans clustering blah blah blah"

   Nonetheless, I think we should expose the underlying text graphic for easier manipulation

   My thought process is:

   subplot.title # returns the graphic
   subplot.title.name # returns the string value
   subplot.title.name # setter
   subplot.title.face_color = "red" # and for other relevant properties
   
   subplot.name # returns the "indexing" name of the subplot

   I think this would make it behave more like the other graphics, and then these properties can behave like features
4. kushalkolar commented on Feb 19, 2025

   

   kushalkolar

   on Feb 19, 2025

   Member

   More actions

   That sounds good to me!
5. kushalkolar

   assigned

   clewis7

   on Feb 20, 2025
6. clewis7 commented on Mar 23, 2025

   

   clewis7

   on Mar 23, 2025

   MemberAuthor

   More actions

   completed in #740
7. clewis7

   closed this as completedon Mar 23, 2025

Issue actions