GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix bug in layout setting by clewis7 · Pull Request #1001 · fastplotlib/fastplotlib

Conversation

@clewis7

@clewis7 clewis7 commented Feb 23, 2026

Copy link
Copy Markdown
Member

There was a reason that I was setting the rect from what was passed

using rect_offset is just to make sure that you don't exceed the canvas, but the original rect accounts for the offset

Sorry, really silly mistake

@kushalkolar, this shouldn't change anything

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@clewis7
fix bug
9a2b08e
@clewis7
clewis7 requested a review from kushalkolar as a code owner February 23, 2026 21:10
kushalkolar
kushalkolar approved these changes Feb 23, 2026
View reviewed changes
@kushalkolar
kushalkolar merged commit 88b4e0f into main Feb 23, 2026
25 of 36 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@github-actions

github-actions Bot commented Feb 23, 2026

Copy link
Copy Markdown

📚 Docs preview built and uploaded! https://www.fastplotlib.org/ver/layout-patch
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@kushalkolar
kushalkolar deleted the layout-patch branch February 24, 2026 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kushalkolar kushalkolar kushalkolar approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@clewis7 @kushalkolar
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.