GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — More interaction by kushalkolar · Pull Request #106 · fastplotlib/fastplotlib

Conversation

@kushalkolar

@kushalkolar kushalkolar commented Jan 8, 2023

Copy link
Copy Markdown
Member
  • bugfix for handling feature events if the event handlers are methods instead of functions
  • bugfix, image has cmap and not colors for feature_events class attr
  • Graphic.link() can be bidirectional using kwarg bidirectional=True
    • Basically if bidirectional=True, Graphic.link() does target.link() with the same arguments. target.link() uses bidirectional=False to prevent infinite recursion.
    • _set_feature() exits (just returns) if the previous_data.indices is identical to the new indices, this was also necessary to prevent infinite recurusion.
    • allow 1D numpy arrays for indexing GraphicCollection

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
kushalkolar added 3 commits January 8, 2023 03:02
@kushalkolar
bugfix for feature event hanlders which are methods
ad89146
@kushalkolar
bugfix, image has cmap as feature not colors
7342150
@kushalkolar
Graphic.link() can be bidirection, fix feature_events cls attrs, allo…
1d3ca3e 
…w 1D numpy array to index GraphicCollection
@kushalkolar
kushalkolar merged commit 4a64391 into master Jan 8, 2023
@kushalkolar kushalkolar mentioned this pull request Jan 9, 2023
interactivity, continued #100
Closed
2 of 3 tasks
@kushalkolar
kushalkolar deleted the more-interaction branch January 9, 2023 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@kushalkolar
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.