GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — "DockedViewport" - Viewports adjacent to `Subplot` `Viewport` by kushalkolar · Pull Request #30 · fastplotlib/fastplotlib

Conversation

@kushalkolar

@kushalkolar kushalkolar commented Oct 11, 2022

Copy link
Copy Markdown
Member

start implementing #29

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
kushalkolar added 3 commits October 11, 2022 01:05
@kushalkolar
some basic ideas for sub_viewports
2df9ee4
@kushalkolar
viewports within subplots working for right side
75a1ab4
@kushalkolar
'docked viewports' within subplots now working well on all sides
0900bde
@kushalkolar

kushalkolar commented Nov 19, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

"docked subplots" now work on any side of a subplot, this will allow making a histogram LUT widget similar to pyqtgraph's

image

things to consider:

  1. make a "view area" class which is kinda like a Subplot, but they can only exist as children of a subplot and are shown within the original Subplot viewport area. Also this way Subplot itself can mostly just keep plotting relevant capabilities.
PlotArea:
    attrs:
        parent
        position
        renderer
        camera
        controller
    methods:
        get_rect()
        set_viewport_rect()
        render()
        add_graphic()
        center_graphic()
...
  1. Start a module for widgets like the HistogramLUTWidget which are more complex than just single Graphic items.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

kushalkolar
kushalkolar commented Nov 19, 2022
View reviewed changes
Comment thread fastplotlib/subplot.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

@kushalkolar
make viewport rect code more readable
4662d3f
@kushalkolar kushalkolar mentioned this pull request Dec 2, 2022
ImageWidget #51
Merged
9 tasks done
@kushalkolar kushalkolar changed the title histogram widget and sub_viewports in Subplot "DockedViewport" - Viewports adjacent to Subplot Viewport Dec 9, 2022
@kushalkolar kushalkolar mentioned this pull request Dec 9, 2022
Roadmap 2026 #55
Open
54 of 78 tasks
kushalkolar added 3 commits December 10, 2022 22:05
@kushalkolar
fix merge conflicts
7630c97
@kushalkolar
new PlotArea base class, subclassed by Subplot and DockedViewport, works
021ef62
@kushalkolar
bug fixes, cleanup, PlotArea repr and str, everything tested and work…
6611a6c
…s, no broken functionality
@kushalkolar
kushalkolar merged commit daf6984 into master Dec 11, 2022
This was referenced Dec 15, 2022
API things, names, consistency, etc. #68
Closed
text #70
Open
@kushalkolar
kushalkolar deleted the histwidget branch January 7, 2023 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@kushalkolar
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.