GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — make hlut widget optional by clewis7 · Pull Request #351 · fastplotlib/fastplotlib

Conversation

@clewis7

@clewis7 clewis7 commented Oct 31, 2023

Copy link
Copy Markdown
Member

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Caitlin Lewis
make hlut widget optional
810f139
@clewis7

clewis7 commented Oct 31, 2023

Copy link
Copy Markdown
Member Author

would be nice to add an hlut button to the toolbar so it can be generated after imagewidget instantiation if a user wanted one for a specific subplot!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
kushalkolar
kushalkolar requested changes Oct 31, 2023
View reviewed changes
Comment thread fastplotlib/widgets/image.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@kushalkolar

kushalkolar commented Oct 31, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

would be nice to add an hlut button to the toolbar so it can be generated after imagewidget instantiation if a user wanted one for a specific subplot!

I think this is feature creep, they can create and add it programmatically if they need that level of customization?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@kushalkolar

kushalkolar commented Nov 1, 2023

Copy link
Copy Markdown
Member

Also add kwarg to specify subsample dims for HistogramLut widget?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
kushalkolar
kushalkolar reviewed Nov 1, 2023
View reviewed changes
Comment thread fastplotlib/widgets/image.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
clewis7
clewis7 commented Nov 1, 2023
View reviewed changes
Comment thread fastplotlib/widgets/image.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
clewis7
clewis7 commented Nov 1, 2023
View reviewed changes
Comment thread fastplotlib/widgets/image.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@clewis7
Apply suggestions from code review
0f76af2
@clewis7

clewis7 commented Nov 1, 2023

Copy link
Copy Markdown
Member Author

Also add kwarg to specify subsample dims for HistogramLut widget?

@kushalkolar anything more than number of bins? or you want a dict that allows user to pass nbins and flank?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@kushalkolar

kushalkolar commented Nov 1, 2023

Copy link
Copy Markdown
Member

Also add kwarg to specify subsample dims for HistogramLut widget?

@kushalkolar anything more than number of bins? or you want a dict that allows user to pass nbins and flank?

Just a tuple of its to specify the max size?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@kushalkolar
kushalkolar marked this pull request as ready for review November 3, 2023 04:06
@kushalkolar

kushalkolar commented Nov 3, 2023

Copy link
Copy Markdown
Member

going to merge this, see #359 for the subsample
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@kushalkolar
kushalkolar merged commit c1cf47f into main Nov 3, 2023
@kushalkolar
kushalkolar deleted the iw_hlut branch November 4, 2023 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kushalkolar kushalkolar kushalkolar requested changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@clewis7 @kushalkolar
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.