GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix normalize_min_max by kushalkolar · Pull Request #353 · fastplotlib/fastplotlib

Conversation

@kushalkolar

@kushalkolar kushalkolar commented Nov 1, 2023

Copy link
Copy Markdown
Member

closes #352

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@kushalkolar
fix normalize_min_max
5373458
@kushalkolar
kushalkolar requested a review from clewis7 November 1, 2023 08:38
@kushalkolar
document utils.get_cmap()
1a21b71
@kushalkolar

kushalkolar commented Nov 1, 2023

Copy link
Copy Markdown
Member Author

Really bizarre failure only on python3.10 in the nb tests O_O. Will just rerun the test, maybe github actions is being weird.

=================================== FAILURES ===================================
_ /home/runner/work/fastplotlib/fastplotlib/examples/notebooks/lines_cmap.ipynb _
---------------------------------------------------------------------------
# for testing, ignore
notebook_finished()
---------------------------------------------------------------------------
AssertionError                            Traceback (most recent call last)
Cell In[19], line 2
      1 # for testing, ignore
----> 2 notebook_finished()

File ~/work/fastplotlib/fastplotlib/examples/notebooks/nb_test_utils.py:85, in notebook_finished()
     83 def notebook_finished():
     84     if len(FAILURES) > 0:
---> 85         raise AssertionError(
     86             f"Failures for plots:\n{FAILURES}"
     87         )

AssertionError: Failures for plots:
['lines-cmap-white', 'lines-cmap-jet', 'lines-cmap-jet-values', 'lines-cmap-jet-values-cosine', 'lines-cmap-viridis', 'lines-cmap-viridis-values', 'lines-cmap-tab-10']
__ /home/runner/work/fastplotlib/fastplotlib/examples/notebooks/simple.ipynb ___
---------------------------------------------------------------------------
# for testing, ignore
notebook_finished()
---------------------------------------------------------------------------
AssertionError                            Traceback (most recent call last)
Cell In[64], line 2
      1 # for testing, ignore
----> 2 notebook_finished()

File ~/work/fastplotlib/fastplotlib/examples/notebooks/nb_test_utils.py:85, in notebook_finished()
     83 def notebook_finished():
     84     if len(FAILURES) > 0:
---> 85         raise AssertionError(
     86             f"Failures for plots:\n{FAILURES}"
     87         )

AssertionError: Failures for plots:
['camera', 'astronaut', 'astronaut_RGB', 'lines', 'lines-colors', 'lines-data', 'lines-underlay', 'lines-3d']
=========================== short test summary info ============================
FAILED examples/notebooks/lines_cmap.ipynb:: - ['lines-cmap-white', 'lines-cmap-jet', 'lines-cmap-jet-values', 'lines-cmap-jet-values-cosine', 'lines-cmap-viridis', 'lines-cmap-viridis-values', 'lines-cmap-tab-10']
FAILED examples/notebooks/simple.ipynb:: - ['camera', 'astronaut', 'astronaut_RGB', 'lines', 'lines-colors', 'lines-data', 'lines-underlay', 'lines-3d']
======================== 2 failed, 10 passed in 47.03s =========================
Error: Process completed with exit code 1.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@kushalkolar
kushalkolar merged commit 430f513 into main Nov 2, 2023
@kushalkolar
kushalkolar deleted the fix-min-max-norm branch November 4, 2023 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@clewis7 clewis7 Awaiting requested review from clewis7 clewis7 is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

weird floating point error in setter for cmap_values

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@kushalkolar
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.