GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — `Plot.auto_scale()` shouldn't change the camera aspect unless desired by kushalkolar · Pull Request #364 · fastplotlib/fastplotlib

Conversation

@kushalkolar

@kushalkolar kushalkolar commented Nov 6, 2023

Copy link
Copy Markdown
Member

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@kushalkolar
now auto_scale() by default does not change camera aspect
ee87d26
@kushalkolar
kushalkolar requested a review from clewis7 November 6, 2023 03:41
kushalkolar added 6 commits November 7, 2023 02:30
@kushalkolar
center_scene() and maintain_aspect() take only kwargs
8e1efd8
@kushalkolar
try CI with bigmem runner again (#363)
363df5a 
bigmem runner works
@kushalkolar
now auto_scale() by default does not change camera aspect
b0be6ef
@kushalkolar
center_scene() and maintain_aspect() take only kwargs
e75c1fd
@kushalkolar
Merge branch 'fix-initial-camera' of https://github.com/fastplotlib/f…
b714426 
…astplotlib into fix-initial-camera
@kushalkolar
update screenshot images after auto_scale() fix
011212a
@kushalkolar

kushalkolar commented Nov 16, 2023

Copy link
Copy Markdown
Member Author

@ArjunPutcha @clewis7 Note that this changes the behavior of auto_scale(). See: https://github.com/fastplotlib/fastplotlib/pull/364/files#diff-2a0f782c81512ab17081f35fd6cac201fafd429eded696cb76981946bc6baaecR511-R513
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@kushalkolar
kushalkolar merged commit 7350b81 into main Nov 16, 2023
@kushalkolar
kushalkolar deleted the fix-initial-camera branch November 16, 2023 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@clewis7 clewis7 Awaiting requested review from clewis7 clewis7 is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@kushalkolar
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.