GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — update contrib guide for git-lfs by tlambert03 · Pull Request #391 · fastplotlib/fastplotlib

Conversation

@tlambert03

@tlambert03 tlambert03 commented Dec 4, 2023

Copy link
Copy Markdown
Contributor

closes #388

@kushalkolar, how's this read?

also, do you ever commit stuff in diffs/? or is it worth adding it to git ignore?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@tlambert03
update contrib
d99b643
kushalkolar
kushalkolar requested changes Dec 4, 2023
View reviewed changes
Comment thread CONTRIBUTING.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
@kushalkolar

kushalkolar commented Dec 4, 2023

Copy link
Copy Markdown
Member

Thanks for this! :D

Yes it should be safe to add diffs/* to .gitignore, but keep the diffs dir.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@kushalkolar

kushalkolar commented Dec 4, 2023

Copy link
Copy Markdown
Member

Nevermind you're right sorry! We don't have an empty diffs dir in main (@clewis7 wrote the entire test suite so I'm sometimes unfamiliar with the details here)
tlambert03 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@tlambert03

tlambert03 commented Dec 4, 2023

Copy link
Copy Markdown
Contributor Author

Right, so the main question (for you all), is whether you ever intend to check stuff into diffs, or if it's always the byproduct product of a test. If the latter, just add it to gitignore, and then developers don't need to pay any special attention to it.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@kushalkolar

kushalkolar commented Dec 5, 2023

Copy link
Copy Markdown
Member

Yup it's indeed the latter!
tlambert03 reacted with rocket emoji
All reactions
  • 🚀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@kushalkolar

kushalkolar commented Dec 5, 2023

Copy link
Copy Markdown
Member

Bypassing CI for this since no source files are touched.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@kushalkolar
kushalkolar merged commit 9621740 into fastplotlib:main Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kushalkolar kushalkolar kushalkolar requested changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Tests: OSError: [Errno 24] Too many open files

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@tlambert03 @kushalkolar
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.