GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gpu info upon notebook import by kushalkolar · Pull Request #410 · fastplotlib/fastplotlib

Conversation

@kushalkolar

@kushalkolar kushalkolar commented Feb 23, 2024

Copy link
Copy Markdown
Member

Displays gpu info when imported in notebooks

image

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
kushalkolar added 2 commits February 23, 2024 18:36
@kushalkolar
displaying fpl logo and gpu info works on import in nb
bb875c5
@kushalkolar
add face logo for nb and add to MANIFEST
364871e
@kushalkolar
kushalkolar requested a review from clewis7 February 24, 2024 07:25
clewis7
clewis7 reviewed Feb 24, 2024
View reviewed changes

@clewis7 clewis7 left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried it locally on my mac and after removing the legends import statement seems to work fine. LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread fastplotlib/__init__.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@kushalkolar

kushalkolar commented Feb 25, 2024

Copy link
Copy Markdown
Member Author

I also need to add git lfs installs to the pypi publish action.

Should probably also wrap the print_gpu_info() call in __init__.py in a try except so that the info banner doesn't block import for any weird reason that doesn't affect fpl functionality.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
kushalkolar added 3 commits February 27, 2024 00:26
@kushalkolar
remove line that snuck in from other branch
8b05dac
@kushalkolar
git lfs to pypi build action
4cd4d04
@kushalkolar
fix import and add easter egg
fdfdcb5
@kushalkolar

kushalkolar commented Feb 27, 2024

Copy link
Copy Markdown
Member Author

glfw tests passing, I will checkout the notebook pixel ratio issue soon
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@kushalkolar
kushalkolar merged commit 7921516 into main Feb 27, 2024
@kushalkolar
kushalkolar deleted the logos-gpu-info branch February 27, 2024 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@clewis7 clewis7 clewis7 left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@kushalkolar @clewis7
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.