GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Draggable Graphics by kushalkolar · Pull Request #413 · fastplotlib/fastplotlib

Conversation

@kushalkolar

@kushalkolar kushalkolar commented Feb 27, 2024

Copy link
Copy Markdown
Member

closes #407

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@kushalkolar
start DragFeature, not tested yet
80b6cfa
@kushalkolar
kushalkolar requested a review from clewis7 February 27, 2024 16:49
kushalkolar added 5 commits February 27, 2024 11:51
@kushalkolar
more stuff for drag
256988b
@kushalkolar
simplify DragFeature, still not tested yet
fcdd4d6
@kushalkolar
graphics are now draggable, tested and works
9552de4
@kushalkolar
small edits
61a79dc
@kushalkolar
small fixes
c8ca809
clewis7
clewis7 reviewed Feb 29, 2024
View reviewed changes

@clewis7 clewis7 left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, purpose of this PR is to create base class for handling moving Graphics?

LGTM codewise

I'm not sure I understand the relevancy of clip and multiplier. It looks like they are mostly always going to be None?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread fastplotlib/graphics/_base.py Outdated
collection_index: int
if relevant, the sub-index of this Graphic within the GraphicCollection

draggable: bool, default ``False``

@clewis7 clewis7 Feb 29, 2024

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to clarify here: at this point in time all graphics are draggable right?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread fastplotlib/graphics/_features/_drag.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
kushalkolar added 2 commits March 1, 2024 01:26
@kushalkolar
add kb drag support, add docstrings to DragFeature
3f9190f
@kushalkolar
Merge branch 'main' into drag-feature
eb60043
@kushalkolar
kushalkolar marked this pull request as ready for review March 1, 2024 06:28
@kushalkolar kushalkolar mentioned this pull request Mar 1, 2024
Basic input class pygfx/pygfx#665
Closed
clewis7
clewis7 reviewed Mar 1, 2024
View reviewed changes
Comment thread fastplotlib/graphics/_base.py
collection_index: int
if relevant, the sub-index of this Graphic within the GraphicCollection

draggable: one of ``None``, ``"mouse"``, ``"kb"``, or ``"mouse+kb"``, default ``None``

@clewis7 clewis7 Mar 1, 2024

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would maybe specify that "kb" here is keyboard

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
clewis7
clewis7 reviewed Mar 1, 2024
View reviewed changes
Comment thread fastplotlib/graphics/_features/_drag.py
return self._multiplier

@multiplier.setter
def multiplier(self, value: np.ndarray):

@clewis7 clewis7 Mar 1, 2024

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should there be more parsing here for size of value passed? Should always be a (1,3)

Also, should we allow passing a single float that would apply to xyz?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@kushalkolar kushalkolar mentioned this pull request Mar 20, 2024
Modes for selector Sychronizer and use of arrow key #262
Closed
4 tasks
@kushalkolar

kushalkolar commented Mar 20, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

on hold until pygfx/pygfx#665
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@kushalkolar
kushalkolar marked this pull request as draft March 23, 2024 03:05
@kushalkolar

kushalkolar commented May 9, 2026

Copy link
Copy Markdown
Member Author

I forgot what usecase this was for, let's close unless we come across a usecase again
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@kushalkolar kushalkolar closed this May 9, 2026
@kushalkolar
kushalkolar deleted the drag-feature branch September 23, 2026 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@clewis7 clewis7 clewis7 left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Base class for moveable Graphic

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@kushalkolar @clewis7
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.