GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — A bit of black by almarklein · Pull Request #433 · fastplotlib/fastplotlib

Conversation

@almarklein

@almarklein almarklein commented Mar 13, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator
  • The script that generates graphic_methods_mixin.py now also blackens the code. (could take this nearly verbatim from the wgpu codegen)
  • Blackend a few more files.

Now only the examples are unblacked. I can add that too if you want, but I was not sure if certain PR's may be affected.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
almarklein added 2 commits March 13, 2024 15:48
@almarklein
Script that generates methods also blackens the code.
f1363e3
@almarklein
Also blacken docs subdir
af70ec8
@almarklein

almarklein commented Mar 13, 2024

Copy link
Copy Markdown
Collaborator Author

I think it makes sense to move the generate_x scripts out of the fastplotlib dir into a special scripts dir in the root of the repo, since they're not part of the library. But generate_colormaps.py is touched in #390, so I left it in place.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@kushalkolar

kushalkolar commented Mar 13, 2024

Copy link
Copy Markdown
Member

I think it makes sense to move the generate_x scripts out of the fastplotlib dir into a special scripts dir in the root of the repo, since they're not part of the library.

Makes sense!

But generate_colormaps.py is touched in #390, so I left it in place.

Yup I need to get back to that PR, probably next week. But generate_colormaps.py will disappear after we incorporate Talley's cmap lib
almarklein reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@almarklein
almarklein marked this pull request as ready for review March 14, 2024 08:15
@kushalkolar
kushalkolar merged commit 8ebbe5c into main Mar 14, 2024
@kushalkolar
kushalkolar deleted the gen_methods branch March 20, 2024 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@almarklein @kushalkolar
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.