GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — sphinx gallery for docs by clewis7 · Pull Request #437 · fastplotlib/fastplotlib

Conversation

@clewis7

@clewis7 clewis7 commented Mar 18, 2024 •
edited by kushalkolar
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

starts #486

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Caitlin Lewis
start to work on adding sphinx gallery for docs
11cc304
@clewis7

clewis7 commented Mar 18, 2024

Copy link
Copy Markdown
Member Author

Currently, the issue that I am running into is that in the conf.py I am forcing offscreen rendering but then when I go to make the html the wgpu canvas is rendering which causes the build process to stall
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
almarklein
almarklein reviewed Mar 18, 2024
View reviewed changes
Comment thread docs/source/conf.py
Comment on lines +20 to +21
def _ignore_offscreen_run():
wgpu.gui.offscreen.run = lambda: None

@almarklein almarklein Mar 18, 2024

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This bit should no longer be necessary. It's from a time when the offscreen backend still fired up asyncio (it does not do so anymore). The WGPU_FORCE_OFFSCREEN is the only thing needed.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@almarklein

almarklein commented Mar 18, 2024

Copy link
Copy Markdown
Collaborator

I happen to be working on pygfx/pygfx#679.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
almarklein
almarklein reviewed Mar 18, 2024
View reviewed changes
Comment thread docs/source/conf.py
# "Light",
# },
"doc_module": ("fastplotlib",),
"image_scrapers": ("fastplotlib",),

@almarklein almarklein Mar 18, 2024

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you put "pygfx" here instead, I think you can use our scraper, so you don;t need the gallery_scraper.py.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@almarklein

almarklein commented Mar 18, 2024

Copy link
Copy Markdown
Collaborator

[...] the wgpu canvas is rendering which causes the build process to stall

Fastplotlib is eagerly trying to use glfw when I try it too, ignoring the offscreen setting. I expect that this should be fixed with #431
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@clewis7 clewis7 closed this May 29, 2024
@kushalkolar
kushalkolar deleted the sphinx-gallery branch June 12, 2024 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@almarklein almarklein almarklein left review comments
@kushalkolar kushalkolar Awaiting requested review from kushalkolar kushalkolar will be requested when the pull request is marked ready for review kushalkolar is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@clewis7 @almarklein
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.