GeezerVison is showing github.com — Use simpler form of super() where possible by almarklein · Pull Request #453 · fastplotlib/fastplotlib
Conversation
almarklein
commented
Mar 27, 2024
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
These caught my eye in my earlier review. Simple fix that makes the code a bit simplere / easier to read, but possibly also avoids bugs.
Context:
class Foo:
def __init__(self):
print("init Foo")
class Bar(Foo):
def __init__(self):
super().__init__()
print("init Bar")
class Spam(Bar):
def __init__(self):
super().__init__()
print("init Spam")
Spam()Produces:
init Foo
init Bar
init Spam
Replacing the super() in Spam with super(Spam, self).__init__() produces the same result.
But if it is replaced with super(Foo, self).__init__(), it produces:
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
|
Also looking into Subplot, which has multiple inheritance.
For reference:
class Foo:
def __init__(self):
super().__init__()
print("init Foo")
class Bar():
def __init__(self):
super().__init__()
print("init Bar")
class Spam(Bar, Foo):
def __init__(self):
super().__init__()
print("init Spam")
Spam()Produces:
init Foo
init Bar
init Spam
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
There's a lot of multiple inheritance when you get to the plots and graphics, and that results in some juggling with super and direct calls to SomeSuperclass.__init__. Will not burn my hands on that right now. Let's keep this pr small 😅
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Reviewers
clewis7
Awaiting requested review from clewis7
clewis7 is a code owner
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.