GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Select gpu by kushalkolar · Pull Request #491 · fastplotlib/fastplotlib

Conversation

@kushalkolar

@kushalkolar kushalkolar commented Apr 16, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

basically wrapper for pygfx/pygfx#709 and pygfx/wgpu-py#481

Adds a fastplotlib.utils.gpu module, and exposes enumerate_adapters, select_adapter, and print_wgpu_report at top level.

Example:

import fastplotlib as fpl

fpl.select_adapter(fpl.enumerate_adapters()[2])

Also added corresponding info to docs: https://fastplotlib--491.org.readthedocs.build/en/491/user_guide/gpu.html#gpu-info

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
kushalkolar added 3 commits April 16, 2024 00:10
@kushalkolar
add functions to choose GPU and get adapter info
afc8645
@kushalkolar
add wgpu to intersphinx
f1f47d8
@kushalkolar
update gpu docs
636183a
@kushalkolar
kushalkolar requested review from almarklein and clewis7 April 16, 2024 04:20
@kushalkolar kushalkolar mentioned this pull request Apr 16, 2024
fpl demo project-improv/improv#149
Draft
almarklein
almarklein reviewed Apr 16, 2024
View reviewed changes

@almarklein almarklein left a comment

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Just 2 small comments.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread docs/source/user_guide/gpu.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread docs/source/user_guide/gpu.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@kushalkolar

kushalkolar commented Apr 16, 2024

Copy link
Copy Markdown
Member Author

Do you think it makes sense to expose this as a top level import? I don't think there's a use case for many more gpu related functions to create a "fpl.gpu" namespace.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
kushalkolar added 3 commits April 16, 2024 11:04
@kushalkolar
update docs
f56b244
@kushalkolar
update docsg
cc3ca29
@kushalkolar
why is rst so weird
532924d
@almarklein

almarklein commented Apr 16, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

Do you think it makes sense to expose this as a top level import? I don't think there's a use case for many more gpu related functions to create a "fpl.gpu" namespace.

In pygfx we deliberately do not make it part of the toplevel namespace, because its not something most users need. Maybe more important, it makes code less portable. But in pygfx we already had a namespace for advanced wgou-specific stuff (gfx.renderers.wgpu). Perhaps introducing a namespace just for this (in fpl) is a bit overkill ...

Maybe put differently ... if fpl is currently a single namespace, I'd just put it in there, I think.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@kushalkolar

kushalkolar commented Apr 16, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

Thanks! I like having your input since you're much much experienced in API design 😄
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@kushalkolar
kushalkolar marked this pull request as ready for review April 16, 2024 21:40
@kushalkolar
kushalkolar merged commit 1abe5ed into main Apr 16, 2024
@kushalkolar
kushalkolar deleted the select-gpu branch April 16, 2024 23:31
@kushalkolar kushalkolar mentioned this pull request Apr 16, 2024
sphinx breaking #492
Closed
@kushalkolar kushalkolar mentioned this pull request Jun 5, 2024
print report #464
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@almarklein almarklein almarklein left review comments
@clewis7 clewis7 Awaiting requested review from clewis7 clewis7 is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@kushalkolar @almarklein
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.