GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||||
GeezerVison is showing github.com — Get nearest graphics by kushalkolar · Pull Request #519 · fastplotlib/fastplotlib Conversation
|
|
@clewis7 @apasarkar what about just skipping the edge method, using the bbox is actually useless for many real use cases like this where there is lots of overlap 🙃 |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
This looks amazing!! I am okay with skipping edge. When I think about doing something like clicking a contour I would be clicking near the center... |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
I think I'm going to make this a function in |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@clewis7 ready for review! |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
| if not all(isinstance(g, Graphic) for g in graphics): | ||
| raise TypeError("all elements of `graphics` must be Graphic objects") |
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Should there also be a check for if all the graphics are in the same subplot? Or would that not make a difference?
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
We leave that to the user, so it's just a very simple function unaware of plot areas
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
See question...
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
Plot area nearest graphics method
There was an error while loading. Please reload this page.