GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — always cast to float32, try to convert other array types too by kushalkolar · Pull Request #527 · fastplotlib/fastplotlib

Conversation

@kushalkolar

@kushalkolar kushalkolar commented Jun 18, 2024

Copy link
Copy Markdown
Member

this always casts data for positions graphics to float32, and it tries to create a numpy array from other array types, shoulud work with jax arrays according to #483

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@kushalkolar
always cast to float32, try to convert other array types too
db7c4a0
@kushalkolar
kushalkolar requested a review from BalzaniEdoardo June 18, 2024 04:50
@kushalkolar
kushalkolar requested a review from clewis7 as a code owner June 18, 2024 04:50
clewis7
clewis7 approved these changes Jun 18, 2024
View reviewed changes
@kushalkolar
kushalkolar merged commit ae9ccc2 into main Jun 18, 2024
@kushalkolar kushalkolar mentioned this pull request Jun 18, 2024
Scatter data isn't casting to float32 #526
Closed
@kushalkolar
kushalkolar deleted the cast-f32 branch June 18, 2024 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@clewis7 clewis7 clewis7 approved these changes
@BalzaniEdoardo BalzaniEdoardo Awaiting requested review from BalzaniEdoardo

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@kushalkolar @clewis7
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.