GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — add colorbar to hlut tool, add `pause_events()` context manager by kushalkolar · Pull Request #550 · fastplotlib/fastplotlib

Conversation

@kushalkolar

@kushalkolar kushalkolar commented Jul 10, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

adds a dynamic colobar to the HistogramLUT tool

cbar-2024-07-10_03.00.57.mp4

@clewis7 this will modify the test screenshot, but I will do that after getting your thoughts on this 😄

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
kushalkolar added 2 commits July 10, 2024 03:02
@kushalkolar
add colorbar to hlut tool
142e67d
@kushalkolar
pause_events contextmanager
67b2b75
@kushalkolar

kushalkolar commented Jul 10, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

I realized there's a better way to manage temporary event blocking, added a context manager that takes Graphics as args and blocks events until the context manager exits.

@clewis7 you will like this :D , simple example:

a = np.random.rand(10, 10)
ig = fpl.ImageGraphic(a)

with fpl.pause_events(ig):
    print("enter context manager")
    print(ig.block_events)
    print("doing some stuff that can cause infinite recursion")
    print(ig.block_events)

print("done doing stuff")
print(ig.block_events)

results in:

enter context manager
True
doing some stuff that can cause infinite recursion
True
done doing stuff
False
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

kushalkolar
kushalkolar commented Jul 10, 2024
View reviewed changes
Comment thread fastplotlib/widgets/histogram_lut.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

@kushalkolar kushalkolar changed the title add colorbar to hlut tool add colorbar to hlut tool, add pause_events() context manager Jul 10, 2024
@kushalkolar
cleanup
323c57c
clewis7
clewis7 reviewed Jul 12, 2024
View reviewed changes
Comment thread fastplotlib/graphics/utils.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

clewis7
clewis7 reviewed Jul 12, 2024
View reviewed changes

@clewis7 clewis7 left a comment •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM aside from maybe adding some code comments

I think the pause_events() will be super useful for pynaviz stuff

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@kushalkolar kushalkolar mentioned this pull request Jul 19, 2024
Histogram widget functionality, vmin, vmap, etc. #557
Open
@kushalkolar

kushalkolar commented Jul 21, 2024

Copy link
Copy Markdown
Member Author

closing because I merged this into axes #551

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@kushalkolar kushalkolar closed this Jul 21, 2024
@kushalkolar
kushalkolar deleted the hlut-cbar branch July 27, 2024 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@clewis7 clewis7 clewis7 left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@kushalkolar @clewis7
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.