GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — catchup with pygfx, remove checks for pending uploads from tests by kushalkolar · Pull Request #562 · fastplotlib/fastplotlib

Conversation

@kushalkolar

@kushalkolar kushalkolar commented Jul 25, 2024

Copy link
Copy Markdown
Member

after pygfx/pygfx#795 Buffer._gfx_pending_uploads no longer exists. There are new methods Buffer.update_full() and Buffer.update_indices() which we can make use of instead of us having to check these ourselves.

One purpose of our test was to make sure that indices chosen to be uploaded correctly mapped to a range and it seems like we don't have to worry about this anymore, thanks @almarklein ! 😄

We should change our BufferManagers to make use of the new buffer upload options! :D

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@kushalkolar
remove checks for pending uploads from tests
79c844c
@kushalkolar
kushalkolar requested a review from clewis7 as a code owner July 25, 2024 08:23
clewis7
clewis7 approved these changes Jul 25, 2024
View reviewed changes
@clewis7
clewis7 merged commit 23e8957 into main Jul 25, 2024
@kushalkolar
kushalkolar deleted the remove-pending-uploads-checks branch July 27, 2024 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@clewis7 clewis7 clewis7 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@kushalkolar @clewis7
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.