GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — change basis of axes by kushalkolar · Pull Request #567 · fastplotlib/fastplotlib

Conversation

@kushalkolar

@kushalkolar kushalkolar commented Jul 29, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

closes #561

WIP, seems to be ok in 2D, something wonky in 3D. Those blue axes should be pointing out towards the red points. And one ruler is completely MIA

download

using pylinalg.quat_from_vecs to create the quaternion to rotate the axes world object.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@kushalkolar
change basis of axes, WIP
d47f002
@kushalkolar
kushalkolar requested a review from clewis7 July 29, 2024 05:15
@kushalkolar
indexing bugfix
8c46029
@kushalkolar

kushalkolar commented Jul 29, 2024

Copy link
Copy Markdown
Member Author

it was an indexing error 🙃

This is really nice 😄

download

I think once I figure out how to get the new (xmin, ymin), (xmax, ymax) for the rulers to account for rotation good to go.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@kushalkolar
kushalkolar marked this pull request as ready for review August 2, 2024 17:17
@kushalkolar
black
9cce798
clewis7
clewis7 approved these changes Aug 2, 2024
View reviewed changes
@kushalkolar
kushalkolar merged commit 68cf50b into main Aug 2, 2024
@kushalkolar
kushalkolar deleted the axes-basis branch August 4, 2024 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@clewis7 clewis7 clewis7 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

adding axes to represent a different basis

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@kushalkolar @clewis7
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.