GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix move to pointer for selectors again by kushalkolar · Pull Request #601 · fastplotlib/fastplotlib

Conversation

@kushalkolar

@kushalkolar kushalkolar commented Sep 2, 2024

Copy link
Copy Markdown
Member

followup from #592

closes #468

This fixes it for LinearRegionSelector too. To make it work with RectangleRegionSelector we need to take the bbox selection and get the center point, and later when we properly implement a PolygonSelector we can just take the mean of all vertices but we can do these later.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
kushalkolar added 3 commits September 2, 2024 17:29
@kushalkolar
LinearSelectionFeature uses np.float32 for selection type
1e037af
@kushalkolar
move_to_pointer which works for both linear and linear region selectors
a5c3516
@kushalkolar
skip move_to_pointer for rectangle selector for now
7841693
@kushalkolar
kushalkolar requested a review from clewis7 as a code owner September 2, 2024 21:35
clewis7
clewis7 approved these changes Sep 12, 2024
View reviewed changes
@clewis7
clewis7 merged commit 9605d06 into main Sep 12, 2024
@kushalkolar
kushalkolar deleted the fix-move-to-pointer-again branch September 16, 2024 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@clewis7 clewis7 clewis7 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

LinearRegionSelector move_to_pointer is buggy

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@kushalkolar @clewis7
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.