GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — add fft example by kushalkolar · Pull Request #605 · fastplotlib/fastplotlib

Conversation

@kushalkolar

@kushalkolar kushalkolar commented Sep 12, 2024

Copy link
Copy Markdown
Member
rectangle_selector_fft-2024-09-11_21.02.56.mp4

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
kushalkolar added 12 commits June 17, 2024 20:48
@kushalkolar
ndarray.ptp -> np.ptp for numpy v2
57702ac
@kushalkolar
Merge branch 'main' of https://github.com/fastplotlib/fastplotlib
eecb5a3
@kushalkolar
Merge branch 'main' of https://github.com/fastplotlib/fastplotlib
ddf13bd
@kushalkolar
Merge branch 'main' of https://github.com/fastplotlib/fastplotlib
d1c9c31
@kushalkolar
Merge branch 'main' of https://github.com/fastplotlib/fastplotlib
ebebc91
@kushalkolar
Merge branch 'main' of https://github.com/fastplotlib/fastplotlib
89bf7cd
@kushalkolar
Merge branch 'main' of https://github.com/fastplotlib/fastplotlib
41f7205
@kushalkolar
Merge branch 'main' of https://github.com/fastplotlib/fastplotlib
47e9979
@kushalkolar
Merge branch 'main' of https://github.com/fastplotlib/fastplotlib
85d278c
@kushalkolar
Merge branch 'main' of https://github.com/fastplotlib/fastplotlib
abab244
@kushalkolar
Merge branch 'main' of https://github.com/fastplotlib/fastplotlib
681fbe3
@kushalkolar
add fft example
16c3d82
@kushalkolar
kushalkolar requested a review from clewis7 as a code owner September 12, 2024 04:43
@kushalkolar kushalkolar mentioned this pull request Sep 12, 2024
I think rows and columns are swapped with the RectangleSelector #604
Closed
@kushalkolar

kushalkolar commented Sep 12, 2024

Copy link
Copy Markdown
Member Author

I suspect CI failures are due to pygfx/wgpu-py#569
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@kushalkolar

kushalkolar commented Sep 12, 2024

Copy link
Copy Markdown
Member Author

@clewis7 the docs build didn't finish after even 20 mins, any ideas? 🤷 will check this later
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@clewis7

clewis7 commented Sep 12, 2024

Copy link
Copy Markdown
Member

@clewis7 the docs build didn't finish after even 20 mins, any ideas? 🤷 will check this later

I am not seeing where it took 20 min to fail, and readthedocs looks like excessive memory consumption

Weird though that CI is passing on only glfw
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@kushalkolar
Merge branch 'main' of https://github.com/fastplotlib/fastplotlib
0df3221
@kushalkolar

kushalkolar commented Sep 17, 2024

Copy link
Copy Markdown
Member Author

I figured it out, will be fixed once pygfx/wgpu-py#587 is merged and next release of WGPU 😆
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
kushalkolar added 4 commits September 17, 2024 13:54
@kushalkolar
Merge branch 'main' of https://github.com/fastplotlib/fastplotlib
ade14ea
@kushalkolar
add fft example
5a7adfd
@kushalkolar
simplify
036befb
@kushalkolar
stupid merge conflict
8015085
clewis7
clewis7 previously approved these changes Sep 17, 2024
View reviewed changes

@clewis7 clewis7 left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checked it out and tried it, LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@kushalkolar

kushalkolar commented Sep 17, 2024 via email

Copy link
Copy Markdown
Member Author
Wait I'll fix the docs size
…
On Tue, Sep 17, 2024, 3:10 PM Caitlin Lewis ***@***.***> wrote: ***@***.**** approved this pull request. checked it out and tried it, LGTM — Reply to this email directly, view it on GitHub <#605 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACHXXRFYSUBLZNNEBDUCEZTZXB5BLAVCNFSM6AAAAABOCKBSEOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGMJQGYZDMNZVGM> . You are receiving this because you authored the thread.Message ID: ***@***.***>
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@kushalkolar
see if it won't complain about smaller size
77ed481
@kushalkolar
kushalkolar dismissed clewis7’s stale review via 77ed481 September 17, 2024 21:16
@kushalkolar

kushalkolar commented Jan 16, 2025

Copy link
Copy Markdown
Member Author

superseeded by #693
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@kushalkolar kushalkolar closed this Jan 16, 2025
@kushalkolar
kushalkolar deleted the fft-example branch January 16, 2025 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@clewis7 clewis7 clewis7 left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@kushalkolar @clewis7
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.