GeezerVison is showing github.com — Cursor tool by kushalkolar · Pull Request #608 · fastplotlib/fastplotlib
Conversation
Make it possible to easily use the cursor to point at the same positions w.r.t. world space across subplots
Idea: when added to a subplot, a new world object is created and added to that subplot. All the world objects across the various subplots use the same buffer.
WIP
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
It would be useful to add crosshairs to multiple graphics in a subplot, in this case it can use the bbox of a graphic as the reference space that it lives in. This is particularly useful when adding multiple images to a subplot in a grid.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
kushalkolar
commented
Sep 26, 2024
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
|
I think I have some better ideas on this after playing with using a scatter dot.
- Allow adding a
Cursor to subplots or Graphics
- The cursor's current "source" position is where the pointer currently is. Either the subplot or the graphic the pointer is on.
- When added to graphics, the cursor's current "source" position is based on the graphic the mouse pointer is currently on. When added to a graphic the cursor's data is always in the same space as the parent graphic's data, i.e.
Cursor.data maps directly to Graphic.data. The offset of an individual cursor matches the offset of the graphic is is on top of. To map from the source graphic to other graphics, just do linear transform, I think this will work:
# w_source, h_source and width and height of source graphic bbox
# w_target, h_target are width and height of target graphic bbox
A = np.array([
[w_target / w_source, 0],
[0, h_target / h_source],
])
u = [source_x, source_y]
target_pos = A @ u
Allowing an arbitrary non-linear transform could also be useful for some visualizations, so allow setting an arbitrary function as a transform.
If the Cursor has a permanent set parent graphic, an inverse transform could also be useful and settable!
-
Allow a cursor to be a scatter point of any shape, one line, or two lines. If a line, then the endpoints are based on the bbox of the graphic or the subplot's extents.
-
When calling target graphics, know what the source graphic was to prevent the source graphic from also becoming a target during that "event call cycle". Could happen if bbox of graphics overlap.
-
When a graphic is deleted, remove it from the cursor list.
-
Have modes, for example to allow double click to "add a marker" that sticks in that location.
-
Let the source graphic either be dynamic (i.e. based on current mouse pointer position), or fixed so it only responds to a fixed source graphic.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
@hmaarrfk, thought you might be interested too, outline of what I'm going to implement is above
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Reviewers
clewis7
Awaiting requested review from clewis7
clewis7 will be requested when the pull request is marked ready for review
clewis7 is a code owner
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
|