GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Get nearest graphics indices by FlynnOConnell · Pull Request #699 · fastplotlib/fastplotlib

Conversation

@FlynnOConnell

@FlynnOConnell FlynnOConnell commented Jan 19, 2025

Copy link
Copy Markdown
Collaborator

closes #682

Helper function to return the indices of the closest graphics in order of closest to the mouse position pos to furthest.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
FlynnOConnell added 2 commits January 18, 2025 23:53
@FlynnOConnell
get_nearest_graphics_indices plot helper
beacf81
@FlynnOConnell
map_screen_to_world can return None
80ef632
kushalkolar
kushalkolar reviewed Jan 24, 2025
View reviewed changes
Comment thread fastplotlib/layouts/_plot_area.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@kushalkolar

kushalkolar commented Jan 24, 2025

Copy link
Copy Markdown
Member

sorry I forgot to review this
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@kushalkolar
kushalkolar marked this pull request as ready for review January 24, 2025 05:07
@kushalkolar
kushalkolar requested a review from clewis7 as a code owner January 24, 2025 05:07
@kushalkolar

kushalkolar commented Jan 24, 2025

Copy link
Copy Markdown
Member

@FlynnOConnell can you black and then I will merge
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@kushalkolar

kushalkolar commented Jan 25, 2025

Copy link
Copy Markdown
Member

can you undo the last commit and only run black on the source files, not the entire repo
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@FlynnOConnell
FlynnOConnell force-pushed the get-nearest-graphics-indices branch from afae226 to 80ef632 Compare January 26, 2025 22:30
@FlynnOConnell
black format source dir only
939700c
FlynnOConnell
FlynnOConnell commented Feb 6, 2025
View reviewed changes

@FlynnOConnell FlynnOConnell left a comment

Copy link
Copy Markdown
Collaborator Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is g2g

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread fastplotlib/layouts/_plot_area.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread fastplotlib/layouts/_plot_area.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@FlynnOConnell
Merge branch 'fastplotlib:main' into get-nearest-graphics-indices
3af774b
kushalkolar
kushalkolar approved these changes Feb 16, 2025
View reviewed changes
@kushalkolar
kushalkolar merged commit c734f02 into fastplotlib:main Feb 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kushalkolar kushalkolar kushalkolar approved these changes
@clewis7 clewis7 Awaiting requested review from clewis7 clewis7 is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

make new helper function get_nearest_graphics_indices()

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@FlynnOConnell @kushalkolar
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.