GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — add macos-latest to CI matrix by kushalkolar · Pull Request #707 · fastplotlib/fastplotlib

Conversation

@kushalkolar

@kushalkolar kushalkolar commented Jan 25, 2025

Copy link
Copy Markdown
Member

let's see if this works

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@kushalkolar
add macos-latest to CI matrix
e334e16
@kushalkolar
kushalkolar requested a review from clewis7 as a code owner January 25, 2025 07:23
kushalkolar added 2 commits January 25, 2025 02:28
@kushalkolar
Update ci.yml
01cb51e
@kushalkolar
fix quotes
a604780
@github-actions

github-actions Bot commented Jan 25, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

📚 Docs preview built and uploaded! https://www.fastplotlib.org/ver/add-mac-ci
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
kushalkolar added 5 commits January 25, 2025 02:40
@kushalkolar
Update ci.yml
222c1a3
@kushalkolar
Update ci.yml
239f8f7
@kushalkolar
Update ci.yml
b023bec
@kushalkolar
Update ci.yml
b5a9e65
@kushalkolar
remove expect lavapipe, not really necessary anymore
c0d1539
@kushalkolar

kushalkolar commented Jan 25, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

mac test failing because there is a slight diff for the lines-data test, will increase tolerance to 0.1 for nb tests, still lower than the default tolerance from the original pygfx code which was 0.2 .

no-imgui-nb-diff-lines-data-rgb
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@kushalkolar
increase tolerance
eb90f95
@kushalkolar kushalkolar mentioned this pull request Jan 25, 2025
try adding mac to ci #660
Closed
@kushalkolar

kushalkolar commented Jan 25, 2025

Copy link
Copy Markdown
Member Author

ok so basically everything that isn't pygfx-latest is passing! 🥳
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@kushalkolar

kushalkolar commented Jan 25, 2025

Copy link
Copy Markdown
Member Author

This mean we'll have over 50 tests with all the variants, but once pygfx becomes more stable it'll go down by half which seems normal for projects of this scope (I looked at matplotlib etc.)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
clewis7
clewis7 approved these changes Jan 25, 2025
View reviewed changes
@clewis7
clewis7 merged commit 0336e26 into main Jan 25, 2025
@clewis7
clewis7 deleted the add-mac-ci branch January 25, 2025 18:05
@kushalkolar

kushalkolar commented Jan 26, 2025

Copy link
Copy Markdown
Member Author

@almarklein thought you might be interested to know that tests now work with the github mac runners 😄
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@almarklein

almarklein commented Jan 27, 2025

Copy link
Copy Markdown
Collaborator

O, that's really cool! 🚀
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@clewis7 clewis7 clewis7 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@kushalkolar @almarklein @clewis7
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.