GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix comment, fix doc example readme file by kushalkolar · Pull Request #769 · fastplotlib/fastplotlib

Conversation

@kushalkolar

@kushalkolar kushalkolar commented Mar 17, 2025

Copy link
Copy Markdown
Member

old comment lingering from when graphics were weakrefs (before we dug into the ways ipython docs gc)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@kushalkolar
fix comment, fix doc example readme file
df3e16c
@kushalkolar
kushalkolar requested a review from clewis7 as a code owner March 17, 2025 02:16
@kushalkolar

kushalkolar commented Mar 17, 2025

Copy link
Copy Markdown
Member Author

Failure makes no sense, I can't produce locally O_O

    def test_gray():
        fig = fpl.Figure()
        ig = fig[0, 0].add_image(GRAY_IMAGE)
        assert isinstance(ig, fpl.ImageGraphic)
    
        ig.add_event_handler(
            event_handler,
            "data",
            "cmap",
            "vmin",
            "vmax",
            "interpolation",
            "cmap_interpolation",
        )
    
        # make sure entire data is the same
        npt.assert_almost_equal(ig.data.value, GRAY_IMAGE)
    
        # since this entire image is under the wgpu max texture limit,
        # the entire image should be in the single Texture buffer
        npt.assert_almost_equal(ig.data.buffer[0, 0].data, GRAY_IMAGE)
    
>       ig.cmap = "viridis"

tests/test_image_graphic.py:89: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
fastplotlib/graphics/image.py:205: in cmap
    self._cmap.set_value(self, name)
fastplotlib/graphics/_features/_base.py:346: in set_value_wrapper
    raise exc  # set_value has raised. The line above and the lines 2+ steps below are probably more relevant!
fastplotlib/graphics/_features/_base.py:343: in set_value_wrapper
    set_value(self, graphic_or_key, value)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

self = <fastplotlib.graphics._features._image.ImageCmap object at 0x114c90410>
graphic = ImageGraphic, value = 'viridis'

    @block_reentrance
    def set_value(self, graphic, value: str):
        new_colors = make_colors(256, value)
>       graphic._material.map.texture.data[:] = new_colors
E       AttributeError: 'TextureMap' object has no attribute 'data'
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@kushalkolar

kushalkolar commented Mar 17, 2025

Copy link
Copy Markdown
Member Author

Ah the change is because cmap now returns a TextureMap instead of a Texture

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@kushalkolar
update get_cmap_texture to return pygfx.Texture since cmap lib changed
cf51ffb
@github-actions

github-actions Bot commented Mar 17, 2025

Copy link
Copy Markdown

📚 Docs preview built and uploaded! https://www.fastplotlib.org/ver/fix-comment-fix-doc-readme

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@kushalkolar

kushalkolar commented Mar 17, 2025

Copy link
Copy Markdown
Member Author

@clewis7 gtg!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

clewis7
clewis7 approved these changes Mar 17, 2025
View reviewed changes
@clewis7
clewis7 merged commit 61d7962 into main Mar 17, 2025
@clewis7
clewis7 deleted the fix-comment-fix-doc-readme branch March 17, 2025 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@clewis7 clewis7 clewis7 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@kushalkolar @clewis7
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.