GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Use pyproject.toml (superseded) by almarklein · Pull Request #779 · fastplotlib/fastplotlib

Conversation

@almarklein

@almarklein almarklein commented Mar 27, 2025

Copy link
Copy Markdown
Collaborator

In future PRs I can do:

  • use same _version.py mechanism as pygfx/wgpu, that e.g. includes nr of commits since last version-tag.
  • Formatting and linting with ruff, perhaps?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@almarklein
almarklein requested review from clewis7 and kushalkolar as code owners March 27, 2025 14:00
@almarklein

almarklein commented Mar 27, 2025

Copy link
Copy Markdown
Collaborator Author

Grrr, I thought I had done git pull but that failed, so this is a bit behind :)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@almarklein
Use pyproject.toml
7201144
@almarklein
almarklein force-pushed the pyproject branch from be8b19c to 7201144 Compare March 27, 2025 14:17
almarklein added 2 commits March 27, 2025 15:22
@almarklein
forgot to safe
968296b
@almarklein
black
a89107e
kushalkolar
kushalkolar requested changes Mar 27, 2025
View reviewed changes
Comment thread pyproject.toml Resolved

Uh oh!

There was an error while loading. Please reload this page.

@kushalkolar

kushalkolar commented Mar 27, 2025

Copy link
Copy Markdown
Member
  • use same _version.py mechanism as pygfx/wgpu, that e.g. includes nr of commits since last version-tag.
  • Formatting and linting with ruff, perhaps?

Sure! I need to go through the codebase and my pycharm and decide how we want to configure ruff, I don't think there's a way to download the rules I'm currently ignoring in pycharm. flake8 is too strict sometimes so we ignore a bunch of things.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

almarklein added 3 commits March 28, 2025 10:02
@almarklein
tweak to allow sed to do its thing
872d9cf
@almarklein
Merge branch 'main' into pyproject
3fb0802
@almarklein
black that one file that ci complains about
be61a44
kushalkolar
kushalkolar reviewed Mar 29, 2025
View reviewed changes
Comment thread fastplotlib/layouts/_graphic_methods_mixin.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread pyproject.toml Resolved

Uh oh!

There was an error while loading. Please reload this page.

@kushalkolar

kushalkolar commented Mar 29, 2025

Copy link
Copy Markdown
Member

So the deploy docs failure is because the secrets are only in the org. If you set your remote origin to https://github.com/fastplotlib/fastplotlib.git and then push and make a new PR it should work.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@almarklein

almarklein commented Mar 29, 2025

Copy link
Copy Markdown
Collaborator Author

If you set your remote origin to https://github.com/fastplotlib/fastplotlib.git and then push and make a new PR it should work.

I'm not sure I understand. Does this mean only PR's from devs with write-access to the main repo can be merged?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@kushalkolar

kushalkolar commented Mar 29, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

If you set your remote origin to https://github.com/fastplotlib/fastplotlib.git and then push and make a new PR it should work.

I'm not sure I understand. Does this mean only PR's from devs with write-access to the main repo can be merged?

We can still see if the docs build step succeeded, but uploading to the server (to see the preview) requires the secrets so we skip it for external contributors for now until we figure out a better way.

almarklein reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@almarklein almarklein mentioned this pull request Mar 29, 2025
Use pyproject.toml #782
Merged
@almarklein

almarklein commented Mar 29, 2025

Copy link
Copy Markdown
Collaborator Author

Superseded by #782

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@almarklein almarklein closed this Mar 29, 2025
@almarklein almarklein changed the title Use pyproject.toml Use pyproject.toml (superseded) Mar 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kushalkolar kushalkolar kushalkolar requested changes
@clewis7 clewis7 Awaiting requested review from clewis7 clewis7 is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@almarklein @kushalkolar
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.