GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Use _version.py that includes details using git by almarklein · Pull Request #784 · fastplotlib/fastplotlib

Conversation

@almarklein

@almarklein almarklein commented Mar 31, 2025

Copy link
Copy Markdown
Collaborator

Using the same module as pygfx and wgpu, which includes more detailed version info when you're inside a git repo.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@almarklein
Use _version.py that includes details using git
e2aa0dc
@almarklein
almarklein requested review from clewis7 and kushalkolar as code owners March 31, 2025 09:55
@github-actions

github-actions Bot commented Mar 31, 2025

Copy link
Copy Markdown

📚 Docs preview built and uploaded! https://www.fastplotlib.org/ver/versioning

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@kushalkolar

kushalkolar commented Apr 1, 2025

Copy link
Copy Markdown
Member

So with this when it's a git version number, it's interpreated as version x.y.z + git-commit? So from now on bump right before release? I would usually bump after a release.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

kushalkolar
kushalkolar approved these changes Apr 1, 2025
View reviewed changes
@kushalkolar
kushalkolar merged commit 8ef6581 into main Apr 1, 2025
@almarklein

almarklein commented Apr 1, 2025

Copy link
Copy Markdown
Collaborator Author

So with this when it's a git version number, it's interpreated as version x.y.z + git-commit?

Yes, e.g. my current pygfx is 0.7.0.post56+g092bc843.dirty, which is 56 commits after the last git vx.y.z tag, the git commit hash is also present. And the .dirty means that I have uncommitted changes :)

So from now on bump right before release? I would usually bump after a release.

Ah, so I guess that in your previous system the main is a bit like a preview (wip) of the upcoming release.

An advantage of bumping right before a release is that you can pick what number to bump, which usually depends a bit on how much (the API) has changed since the previous release.

I don't want to force either system on you. Actually, you could still bump after a release, and we could change the post to pre 🤷

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@kushalkolar

kushalkolar commented Apr 1, 2025

Copy link
Copy Markdown
Member

Ah, so I guess that in your previous system the main is a bit like a preview (wip) of the upcoming release.

yup, let's just follow the same system for fpl after the next release, easier for everyone!

almarklein reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@kushalkolar
kushalkolar deleted the versioning branch April 18, 2025 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kushalkolar kushalkolar kushalkolar approved these changes
@clewis7 clewis7 Awaiting requested review from clewis7 clewis7 is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@almarklein @kushalkolar
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.